chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 2, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
force-pushed
the
avivg/blockifier/impl_enforce_fee_by_api_executable
branch
from
0e846bc to
3444829
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
d1f3d9d to
3ee98a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
===========================================
+ Coverage 40.10% 59.55% +19.45%
===========================================
Files 26 151 +125
Lines 1895 18493 +16598
Branches 1895 18493 +16598
===========================================
+ Hits 760 11014 +10254
- Misses 1100 6776 +5676
- Partials 35 703 +668 ☔ View full report in Codecov by Sentry. |
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
2 times, most recently
from
17dc894 to
16eed33
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/impl_enforce_fee_by_api_executable
branch
from
3444829 to
7516271
Compare
Yoni-Starkware
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Reviewed 7 of 11 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
16eed33 to
c5e3b6f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/impl_enforce_fee_by_api_executable
branch
2 times, most recently
from
32a285b to
0c02023
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
c5e3b6f to
4eff1f1
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/impl_enforce_fee_by_api_executable
branch
from
0c02023 to
3366036
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
4eff1f1 to
cce03af
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/impl_enforce_fee_by_api_executable
branch
from
3366036 to
0502be4
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
cce03af to
48dec19
Compare
avivg-starkware
changed the base branch from
avivg/blockifier/impl_enforce_fee_by_api_executable
to
graphite-base/2412
avivg-starkware
force-pushed
the
graphite-base/2412
branch
from
0502be4 to
8d81548
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
48dec19 to
51280fe
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
from
51280fe to
c448144
Compare
avivg-starkware
commented
Dec 3, 2024
There was a problem hiding this comment.
Reviewed 7 of 11 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
avivg-starkware
deleted the
avivg/blockifier/invoke_declare_deployaccount_change_ret_type
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.