Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): verify block number on propose block #2340

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.21%. Comparing base (e3165c4) to head (fe2593b).
Report is 654 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher/src/batcher.rs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2340       +/-   ##
==========================================
- Coverage   40.10%   5.21%   -34.89%     
==========================================
  Files          26     145      +119     
  Lines        1895   17076    +15181     
  Branches     1895   17076    +15181     
==========================================
+ Hits          760     891      +131     
- Misses       1100   16127    +15027     
- Partials       35      58       +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch from 7de50f1 to 3021db8 Compare November 28, 2024 15:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 9ad8065 to 7fc654e Compare November 28, 2024 15:34
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch from 3021db8 to b8050db Compare December 1, 2024 12:31
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 7fc654e to 14db3f5 Compare December 1, 2024 12:34
@ArniStarkware ArniStarkware changed the title chore(batcher): verify block number on propose block chore(starknet_batcher): verify block number on propose block Dec 1, 2024
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch from b8050db to b173393 Compare December 2, 2024 09:23
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 14db3f5 to 8270819 Compare December 2, 2024 09:23
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_height_as_proposal_input branch 2 times, most recently from 36ecfc6 to b63149a Compare December 2, 2024 13:22
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 8270819 to 02e7c3d Compare December 2, 2024 13:22
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

Copy link
Contributor Author

ArniStarkware commented Dec 2, 2024

Merge activity

  • Dec 2, 8:47 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 2, 8:49 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 2, 8:59 AM EST: A user merged this pull request with Graphite.

@ArniStarkware ArniStarkware changed the base branch from arni/batcher/block_builder_factory/set_height_as_proposal_input to graphite-base/2340 December 2, 2024 13:47
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2340 to main December 2, 2024 13:47
@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 02e7c3d to fe2593b Compare December 2, 2024 13:48
@ArniStarkware ArniStarkware merged commit 2daa67d into main Dec 2, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants