feat(blockifier): two allocation_cost gas vectors #2293
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)
a discussion (no related file):
Python side:
https://reviewable.io/reviews/starkware-industries/starkware/36329
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
===========================================
+ Coverage 40.10% 68.88% +28.77%
===========================================
Files 26 108 +82
Lines 1895 13959 +12064
Branches 1895 13959 +12064
===========================================
+ Hits 760 9615 +8855
- Misses 1100 3933 +2833
- Partials 35 411 +376 ☔ View full report in Codecov by Sentry. |
yoavGrs
force-pushed
the
yoav/compression/extend_allocation_cost_constant
branch
from
b4ec887 to
cbd4c69
Compare
yoavGrs
changed the base branch from
main
to
yoav/compression/allocated_keys_logic
There was a problem hiding this comment.
Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs and @Yoni-Starkware)
crates/blockifier/resources/versioned_constants_0_13_4.json line 49 at r2 (raw file):
}, "gas_cost": { "l1_gas": 551,
how is this number computed?
Code quote:
"l1_gas": 551
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)
crates/blockifier/resources/versioned_constants_0_13_4.json line 49 at r2 (raw file):
Previously, dorimedini-starkware wrote…
how is this number computed?
is this the case where we use calldata instead of blobs?
yoavGrs
changed the base branch from
yoav/compression/allocated_keys_logic
to
graphite-base/2293
yoavGrs
force-pushed
the
graphite-base/2293
branch
from
115054e to
3cd0c6d
Compare
yoavGrs
force-pushed
the
yoav/compression/extend_allocation_cost_constant
branch
from
cbd4c69 to
207c7e3
Compare
yoavGrs
force-pushed
the
yoav/compression/extend_allocation_cost_constant
branch
from
207c7e3 to
27b9ddb
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @nimrod-starkware, and @Yoni-Starkware)
crates/blockifier/resources/versioned_constants_0_13_4.json line 49 at r2 (raw file):
Previously, nimrod-starkware wrote…
is this the case where we use calldata instead of blobs?
it's eth_gas_constants::SHARP_GAS_PER_DA_WORD
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
No description provided.