Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): share class hash syscalls code #2282

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload workflows:

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (e3165c4) to head (936a364).
Report is 590 commits behind head on main.

Files with missing lines Patch % Lines
.../blockifier/src/execution/syscalls/syscall_base.rs 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2282       +/-   ##
===========================================
+ Coverage   40.10%   68.67%   +28.56%     
===========================================
  Files          26      108       +82     
  Lines        1895    13910    +12015     
  Branches     1895    13910    +12015     
===========================================
+ Hits          760     9552     +8792     
- Misses       1100     3948     +2848     
- Partials       35      410      +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)

Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@Yoni-Starkware Yoni-Starkware merged commit 42db010 into main Nov 26, 2024
13 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/syscall-handler/share-class-hash-syscalls branch November 26, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants