refactor(blockifier): move get_block_hash_base to syscallHandlerBase #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
===========================================
+ Coverage 40.10% 68.58% +28.47%
===========================================
Files 26 109 +83
Lines 1895 13903 +12008
Branches 1895 13903 +12008
===========================================
+ Hits 760 9535 +8775
- Misses 1100 3959 +2859
- Partials 35 409 +374 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Yoni-Starkware
force-pushed
the
yoni/syscall-handler/box-base
branch
from
23a588f to
c00f228
Compare
Yoni-Starkware
force-pushed
the
yoni/syscall-handler/mv-get-block-hash-to-base
branch
from
0ba28bb to
19260eb
Compare
amosStarkware
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Yoni-Starkware
force-pushed
the
yoni/syscall-handler/mv-get-block-hash-to-base
branch
from
19260eb to
a447ab4
Compare
Yoni-Starkware
changed the base branch from
yoni/syscall-handler/box-base
to
main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.