chore(blockifier): replace entry_point_gas_cost with initial_budget #2247

Yonatan-Starkware · 2024-11-24T12:37:53Z

No description provided.

Yonatan-Starkware · 2024-11-24T12:38:01Z

chore(blockifier): add syscalls_gas_costs struct #2359 : 2 dependent PRs (#2501 , #2514 )
chore(blockifier): add keccak_builtin_gas_cost #2327
chore(blockifier): replace entry_point_gas_cost with initial_budget #2247 👈 (View in Graphite)
feat(blockifier): add get_syscall_gas_cost to versioned constants impl #2188
feat(blockifier): add impl for GasCosts in versioned_constants #2067
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

reviewable-StarkWare · 2024-11-24T12:38:09Z

This change is

github-actions · 2024-11-24T12:40:10Z

codecov · 2024-11-24T13:38:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (e3165c4) to head (fd9ffbe).
Report is 703 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2247       +/-   ##
===========================================
+ Coverage   40.10%   71.11%   +31.01%     
===========================================
  Files          26      102       +76     
  Lines        1895    13715    +11820     
  Branches     1895    13715    +11820     
===========================================
+ Hits          760     9754     +8994     
- Misses       1100     3547     +2447     
- Partials       35      414      +379

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

meship-starkware

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avi-starkware, @Yonatan-Starkware, and @Yoni-Starkware)

crates/blockifier/src/versioned_constants_test.rs line 25 at r1 (raw file):

            "entry_point_initial_budget": 4,
            "step_gas_cost": 5
        },

It bothers me a bit because this is not how transaction gas cost would look in 0.13.4 and further, but AFAIK, this test will only apply to the older versions, so I think it is OK

Code quote:

        },
        "transaction_gas_cost": {
            "entry_point_initial_budget": 4,
            "step_gas_cost": 5
        },

crates/blockifier/resources/versioned_constants_0_13_2.json line 640 at r1 (raw file):

        ]
    }
}

Add an empty line to this file.

Code quote:

  

crates/blockifier/resources/versioned_constants_0_13_2_1.json line 640 at r1 (raw file):

        ]
    }
}

Same

crates/blockifier/resources/versioned_constants_0_13_3.json line 640 at r1 (raw file):

        ]
    }
}

Same

Yonatan-Starkware · 2024-11-28T10:09:09Z

crates/blockifier/cairo_native line 1 at r2 (raw file):

Subproject commit 76e83965d3bf1252eb6c68200a3accd5fd1ec004

reminder: solve this before merging

Yoni-Starkware

Reviewed 12 of 12 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @avi-starkware and @Yonatan-Starkware)

Yonatan-Starkware

Reviewable status: 12 of 14 files reviewed, 3 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @Yoni-Starkware)

crates/blockifier/resources/versioned_constants_0_13_2.json line 640 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Add an empty line to this file.

Done.

crates/blockifier/resources/versioned_constants_0_13_2_1.json line 640 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Same

Done.

crates/blockifier/resources/versioned_constants_0_13_3.json line 640 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Same

Done.

meship-starkware

Reviewed 10 of 12 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

Yoni-Starkware

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

Yoni-Starkware

Reviewed 2 of 13 files at r1, 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

meship-starkware

Reviewed 11 of 11 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

* chore(starknet_batcher): delete obsolete todo (starkware-libs#2389) * chore(blockifier): add global max_sierra_gas to versioned constants (starkware-libs#2330) * feat(starknet_api): checked mul for gas vector (starkware-libs#2300) * feat(consensus): proposer rotates across validators (starkware-libs#2405) * feat(sequencing): validate streamed proposals (starkware-libs#2305) * feat(ci): deny rust warnings in all workflows (starkware-libs#2388) Signed-off-by: Dori Medini <[email protected]> * feat(blockifier): compute allocation cost (starkware-libs#2301) * chore(starknet_sequencer_infra): add dynamic logging util fn commit-id:9ffe9fbe * chore(starknet_sequencer_infra): add tracing test commit-id:76d16e9a * chore(starknet_sequencer_infra): add run_until utility fn commit-id:194a4b6c * chore(infra_utils): change run_until to support async functions commit-id:92e1f8a3 * chore(starknet_integration_tests): use run_until to await for block creation commit-id:667e001c * chore(infra_utils): rename logger struct commit-id:6520ae54 * chore(blockifier): explicit creation of AccountTransaction (starkware-libs#2331) * test(starknet_integration_tests): test commit blocks by running multiple heights * chore(starknet_batcher): set temp gas prices in propose block input (starkware-libs#2341) * chore(starknet_batcher): set use_kzg_da flag in build block input (starkware-libs#2345) * feat(ci): inherit the rust toolchain toml in moonrepo action (starkware-libs#2423) Signed-off-by: Dori Medini <[email protected]> * chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction (starkware-libs#2377) * chore(starknet_integration_tests): inherit sequencer node's stdout (starkware-libs#2427) * chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx (starkware-libs#2412) * chore(starknet_consensus_manager): set proposer address in propose block input (starkware-libs#2346) * feat(consensus): add observer mode * feat(consensus): sequencer context broadcasts votes (starkware-libs#2422) * chore(deployment): support unified deployment config (starkware-libs#2378) * feat(starknet_api): add sierra version to class info (starkware-libs#2313) * refactor(starknet_api): change default sierra contract class to valid one (starkware-libs#2439) * feat(starknet_l1_provider): add uninitiailized state and make it the default (starkware-libs#2434) This is to comply with upcoming integration with infra, which separates instantiation with initialization. In particular, `Pending` state should be already post-syncing with L1, whereas `Uninitialized` is unsynced and unusable. Co-Authored-By: Gilad Chase <[email protected]> * feat(papyrus_storage)!: bump storage version for version 13.4 (starkware-libs#2333) * feat(native_blockifier): allow deserialization of python l1_data_gas (starkware-libs#2447) * refactor(blockifier): split FC to groups base on their tags (starkware-libs#2236) * test(consensus): remove warning on into mock propsal part (starkware-libs#2448) * chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() (starkware-libs#2428) * chore(blockifier): save sierra to Feature contracts (starkware-libs#2370) * feat(blockifier): don't count Sierra gas in CairoSteps mode (starkware-libs#2440) * chore(blockifier): convert Sierra gas to L1 gas if in L1 gas mode (starkware-libs#2451) * feat(blockifier): add comprehensive state diff versioned constant (starkware-libs#2407) * chore(starknet_consensus_manager): add chain_id to config * refactor(papyrus_p2p_sync): add random_header utility function (starkware-libs#2381) * chore(starknet_batcher): pass block info from consensus to batcher (starkware-libs#2238) * test(starknet_mempool): tx added to mempool are forwarded to propagator client (starkware-libs#2288) * fix: fix CR comments * test(starknet_mempool): tx added to mempool are forwarded to propagator client * feat(sequencing): cache proposals from bigger heights(starkware-libs#2325) * fix: change to latest ubuntu version in feature combo CI (starkware-libs#2414) * chore(blockifier): replace entry_point_gas_cost with initial_budget (starkware-libs#2247) * test(starknet_gateway): handle todo in test_get_block_info (starkware-libs#2267) * chore(starknet_api): revert use get_packaget_dir instead of env var This reverts commit c45f5cc. commit-id:a48736e7 * chore(starknet_api): rely on env::current_dir() instead of CARGO_MANIFEST_DIR commit-id:301ed4eb * chore(blockifier): move env var from run time to compile time commit-id:80a7265d * chore(starknet_sierra_compile): move env var from run time to compile time commit-id:6e7f2a75 * chore: remove the use of zero as a validator id (starkware-libs#2411) * refactor(papyrus_p2p_sync): add_test receives query size instead of constant (starkware-libs#2379) * fix(blockifier): merge state diff with squash (starkware-libs#2310) * feat(blockifier): get revert receipt only in case of revert (starkware-libs#2471) * chore(starknet_integration_tests): create chain info once (starkware-libs#2482) * chore(starknet_sierra_compile): split build utils commit-id:0f504fd7 * chore(starknet_sierra_compile): set runtime-accessible out_dir env var commit-id:539f16db * chore(starknet_sierra_compile): avoid using OUT_DIR in run time commit-id:cd6fba29 * refactor(starknet_api): use const in sierra version (starkware-libs#2477) * chore: cleanups of OUT_DIR env var (starkware-libs#2484) commit-id:18d61b1d * chore(starknet_api): shorten executable_transaction usage path * fix(sequencing): remove old proposal pipes from consensus (starkware-libs#2452) * test(starknet_integration_tests): match sequencer address with default validator id (starkware-libs#2486) * fix(ci): move specific versioned deps to root toml (starkware-libs#2487) * fix(ci): move specific versioned deps to root toml Signed-off-by: Dori Medini <[email protected]> * fix(starknet_sierra_compile): fix build.rs Signed-off-by: Dori Medini <[email protected]> * chore(starknet_batcher): in block builder use the consensus suplied sequncer address (starkware-libs#2409) * chore: cleanups of CARGO_MANIFEST_DIR env var commit-id:c96f2d88 * fix(starknet_sierra_compile): missing import in feature (starkware-libs#2495) commit-id:abd0a286 * chore(blockifier): add keccak_builtin_gas_cost (starkware-libs#2327) * chore(blockifier): add struct ExecutionFlags to AccTx & use instead of transaction::ExecutionFlags (starkware-libs#2429) * chore(blockifier): add new constructor to AccountTransaction (starkware-libs#2431) * chore(blockifier): remove only_qury from IvokeTxArgs (starkware-libs#2437) * chore(blockifier): remove struct ExecutionFlags and replace w concurrency_mode bool (starkware-libs#2470) * chore(blockifier): remove declare.rs deploy_account.rs invoke.rs from blockifier (starkware-libs#2478) --------- Signed-off-by: Dori Medini <[email protected]> Co-authored-by: YaelD <[email protected]> Co-authored-by: aner-starkware <[email protected]> Co-authored-by: yoavGrs <[email protected]> Co-authored-by: matan-starkware <[email protected]> Co-authored-by: guy-starkware <[email protected]> Co-authored-by: dorimedini-starkware <[email protected]> Co-authored-by: Itay Tsabary <[email protected]> Co-authored-by: avivg-starkware <[email protected]> Co-authored-by: Yair Bakalchuk <[email protected]> Co-authored-by: Arnon Hod <[email protected]> Co-authored-by: Alon Haramati <[email protected]> Co-authored-by: Asmaa Magdoub <[email protected]> Co-authored-by: alon-dotan-starkware <[email protected]> Co-authored-by: AvivYossef-starkware <[email protected]> Co-authored-by: giladchase <[email protected]> Co-authored-by: Gilad Chase <[email protected]> Co-authored-by: DvirYo-starkware <[email protected]> Co-authored-by: nimrod-starkware <[email protected]> Co-authored-by: Meshi Peled <[email protected]> Co-authored-by: Yoni <[email protected]> Co-authored-by: Yael Doweck <[email protected]> Co-authored-by: ShahakShama <[email protected]> Co-authored-by: Alon-Lukatch-Starkware <[email protected]> Co-authored-by: Yonatan-Starkware <[email protected]> Co-authored-by: Yair <[email protected]> Co-authored-by: Itay-Tsabary-Starkware <[email protected]>

This was referenced Nov 24, 2024

feat(blockifier): add impl for GasCosts in versioned_constants #2067

Merged

feat(blockifier): add get_syscall_gas_cost to versioned constants impl #2188

Merged

Yonatan-Starkware requested review from avi-starkware, meship-starkware and Yoni-Starkware November 24, 2024 12:38

Yonatan-Starkware marked this pull request as ready for review November 24, 2024 12:38

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 0268017 to 295470e Compare November 24, 2024 12:43

Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from 8e62d52 to 3aa46ab Compare November 24, 2024 12:48

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch 2 times, most recently from 229d2c2 to 0fe8c7e Compare November 24, 2024 13:31

Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from 3aa46ab to dbae55c Compare November 24, 2024 13:33

Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from dbae55c to 58755ee Compare November 24, 2024 14:22

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 0fe8c7e to e9b3ba4 Compare November 24, 2024 14:22

Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch 2 times, most recently from d7b5bc8 to c0ec97c Compare November 24, 2024 14:57

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch 2 times, most recently from d488544 to 49bcd57 Compare November 24, 2024 15:10

Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch 3 times, most recently from 7bf221e to 03ea98e Compare November 24, 2024 16:18

meship-starkware requested changes Nov 27, 2024

View reviewed changes

Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from 03ea98e to e5ebc1e Compare November 28, 2024 08:03

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 49bcd57 to b3bffc7 Compare November 28, 2024 08:43

Yonatan-Starkware changed the base branch from yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it to graphite-base/2247 November 28, 2024 08:53

Yonatan-Starkware force-pushed the graphite-base/2247 branch from e5ebc1e to 8edd6d7 Compare November 28, 2024 08:54

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from b3bffc7 to e179def Compare November 28, 2024 08:54

Yonatan-Starkware changed the base branch from graphite-base/2247 to main November 28, 2024 08:54

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch 2 times, most recently from 8ceb897 to 1ed93f2 Compare November 28, 2024 09:53

Yonatan-Starkware mentioned this pull request Nov 28, 2024

chore(blockifier): add keccak_builtin_gas_cost #2327

Merged

Yoni-Starkware approved these changes Nov 28, 2024

View reviewed changes

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 1ed93f2 to a6ab8e9 Compare November 28, 2024 16:19

Yonatan-Starkware mentioned this pull request Nov 28, 2024

chore(blockifier): add syscalls_gas_costs struct #2359

Merged

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from a6ab8e9 to eb49580 Compare November 28, 2024 16:35

Yonatan-Starkware commented Nov 28, 2024

View reviewed changes

meship-starkware approved these changes Nov 28, 2024

View reviewed changes

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch 2 times, most recently from 1b6f311 to 6409281 Compare December 1, 2024 12:09

Yoni-Starkware approved these changes Dec 1, 2024

View reviewed changes

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 6409281 to bb1a527 Compare December 1, 2024 15:59

Yoni-Starkware approved these changes Dec 1, 2024

View reviewed changes

chore(blockifier): replace entry_point_gas_cost with initial_budget

fd9ffbe

Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from bb1a527 to fd9ffbe Compare December 5, 2024 07:12

meship-starkware approved these changes Dec 5, 2024

View reviewed changes

Yonatan-Starkware merged commit 1ba00f0 into main Dec 5, 2024
13 checks passed

Yonatan-Starkware mentioned this pull request Dec 5, 2024

chore(blockifier): add ecdsa_gas_cost #2501

Closed

github-actions bot locked and limited conversation to collaborators Dec 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(blockifier): replace entry_point_gas_cost with initial_budget #2247

chore(blockifier): replace entry_point_gas_cost with initial_budget #2247

Yonatan-Starkware commented Nov 24, 2024

Yonatan-Starkware commented Nov 24, 2024 •

edited

Loading

reviewable-StarkWare commented Nov 24, 2024

github-actions bot commented Nov 24, 2024 •

edited

Loading

codecov bot commented Nov 24, 2024 •

edited

Loading

meship-starkware left a comment

Yonatan-Starkware commented Nov 28, 2024

Yoni-Starkware left a comment

Yonatan-Starkware left a comment

meship-starkware left a comment

Yoni-Starkware left a comment

Yoni-Starkware left a comment

meship-starkware left a comment

chore(blockifier): replace entry_point_gas_cost with initial_budget #2247

chore(blockifier): replace entry_point_gas_cost with initial_budget #2247

Conversation

Yonatan-Starkware commented Nov 24, 2024

Yonatan-Starkware commented Nov 24, 2024 • edited Loading

reviewable-StarkWare commented Nov 24, 2024

github-actions bot commented Nov 24, 2024 • edited Loading

codecov bot commented Nov 24, 2024 • edited Loading

Codecov Report

meship-starkware left a comment

Choose a reason for hiding this comment

Yonatan-Starkware commented Nov 28, 2024

Yoni-Starkware left a comment

Choose a reason for hiding this comment

Yonatan-Starkware left a comment

Choose a reason for hiding this comment

meship-starkware left a comment

Choose a reason for hiding this comment

Yoni-Starkware left a comment

Choose a reason for hiding this comment

Yoni-Starkware left a comment

Choose a reason for hiding this comment

meship-starkware left a comment

Choose a reason for hiding this comment

Yonatan-Starkware commented Nov 24, 2024 •

edited

Loading

github-actions bot commented Nov 24, 2024 •

edited

Loading

codecov bot commented Nov 24, 2024 •

edited

Loading