-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove &self arg from AccountTransaction::handle_fee #218
fix: remove &self arg from AccountTransaction::handle_fee #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @tdelabro)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)
6a74ce0
to
c9cf640
Compare
@meship-starkware the CI was failing, I rebased on main's latest commit. Let's see if it fixes it. Can you run the CI again please? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 76.62% 71.51% -5.11%
==========================================
Files 351 85 -266
Lines 37223 10859 -26364
Branches 37223 10859 -26364
==========================================
- Hits 28522 7766 -20756
+ Misses 6388 2695 -3693
+ Partials 2313 398 -1915 ☔ View full report in Codecov by Sentry. |
fixes: starkware-libs/blockifier#1770
This change is