chore(blockifier): share the utility felt_to_u128 to starknet api

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(blockifier): share the utility felt_to_u128 to starknet api #2093 👈 (View in Graphite)
• chore(blockifier): make the utility felt_to_u128 private #2095
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[ArniStarkware]

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @barak-b-starkware, @dorimedini-starkware, and @noaov1)

---

crates/starknet_api/src/core_test.rs line 131 at r1 (raw file):

        format!("{error}"),
        "Out of range Felt 340282366920938463463374607431768211456 is too big to convert to \
         'u128'."

Note the format changed slightly.

Code quote:

        "Out of range Felt 340282366920938463463374607431768211456 is too big to convert to \
         'u128'."

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (e3165c4) to head (bdc6877).
Report is 915 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2093       +/-   ##
===========================================
+ Coverage   40.10%   77.29%   +37.18%     
===========================================
  Files          26      378      +352     
  Lines        1895    40029    +38134     
  Branches     1895    40029    +38134     
===========================================
+ Hits          760    30939    +30179     
- Misses       1100     6800     +5700     
- Partials       35     2290     +2255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @barak-b-starkware, and @noaov1)

---

crates/blockifier/src/abi/sierra_types.rs line 46 at r1 (raw file):

pub fn felt_to_u128(felt: &Felt) -> Result<u128, SierraTypeError> {
    felt.to_u128().ok_or_else(|| SierraTypeError::ValueTooLargeForType { val: *felt, ty: "u128" })
}

isn't it an issue that the returned error type has changed now in the blockifier crate?

Code quote:

pub fn felt_to_u128(felt: &Felt) -> Result<u128, SierraTypeError> {
    felt.to_u128().ok_or_else(|| SierraTypeError::ValueTooLargeForType { val: *felt, ty: "u128" })
}

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @barak-b-starkware, and @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ArniStarkware]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @barak-b-starkware, @dorimedini-starkware, and @noaov1)

---

crates/blockifier/src/abi/sierra_types.rs line 46 at r1 (raw file):

Previously, dorimedini-starkware wrote…

isn't it an issue that the returned error type has changed now in the blockifier crate?

This function is only used in the context of this file.
The error is propagated to the OS, so I am not sure.

In any case - I created another PR under this on: #2095. It tries to be in the path of least resistance, yet it solves some issues I have with other projects I am working on.

---

crates/blockifier/src/abi/sierra_types.rs line 68 at r1 (raw file):

        Ok(Self { val: felt_to_u128(&felt)? })
    }
}

These are the two places where felt_to_u128 is used (in a non-test setting).

Code quote:

impl SierraType for SierraU128 {
    fn from_memory(vm: &VirtualMachine, ptr: &mut Relocatable) -> SierraTypeResult<Self> {
        let felt = vm.get_integer(*ptr)?;
        *ptr = (*ptr + 1)?;
        Ok(Self { val: felt_to_u128(&felt)? })
    }

    fn from_storage(
        state: &dyn StateReader,
        contract_address: &ContractAddress,
        key: &StorageKey,
    ) -> SierraTypeResult<Self> {
        let felt = state.get_storage_at(*contract_address, *key)?;
        Ok(Self { val: felt_to_u128(&felt)? })
    }
}

[dorimedini-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

---

crates/blockifier/src/abi/sierra_types.rs line 68 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

These are the two places where felt_to_u128 is used (in a non-test setting).

who uses SierraU128...?

[github-actions]

Artifacts upload triggered. View details here

[ArniStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

---

crates/blockifier/src/abi/sierra_types.rs line 68 at r1 (raw file):

Previously, dorimedini-starkware wrote…

who uses SierraU128...?

Only in this file, only for SierraU256. In turn, SeirraU256 is only used in secp.rs

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.339 ms 34.365 ms 34.397 ms]
change: [-3.9078% -2.4421% -1.1572%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severe

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here