-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add batcher and com prep #204
feat: add batcher and com prep #204
Conversation
006c2af
to
6427c60
Compare
Benchmark movements: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 76.89% 76.82% -0.08%
==========================================
Files 316 317 +1
Lines 34504 34546 +42
Branches 34504 34546 +42
==========================================
+ Hits 26532 26539 +7
- Misses 5687 5722 +35
Partials 2285 2285 ☔ View full report in Codecov by Sentry. |
6427c60
to
b1a050b
Compare
c6a5133
to
ad45c95
Compare
b1a050b
to
6228100
Compare
Benchmark movements: |
6228100
to
cae51bf
Compare
ad45c95
to
aee8b6b
Compare
Benchmark movements: |
Benchmark movements: |
cae51bf
to
051f29e
Compare
aee8b6b
to
75b2272
Compare
051f29e
to
b92c64b
Compare
75b2272
to
5e9993f
Compare
Benchmark movements: |
b92c64b
to
2473411
Compare
5e9993f
to
503e4c9
Compare
Benchmark movements: |
2473411
to
b1de978
Compare
561e1b2
to
7e8445b
Compare
b1de978
to
6f774ba
Compare
Benchmark movements: |
Benchmark movements: |
9105827
to
d4c69b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/batcher/src/communication.rs
line 16 at r1 (raw file):
use crate::batcher::Batcher; pub type BatcherServer = LocalComponentServer<Batcher, BatcherRequest, BatcherResponse>;
Suggestion:
LocalBatcherServer
crates/batcher/src/communication.rs
line 20 at r1 (raw file):
pub type RemoteBatcherServer = RemoteComponentServer<Batcher, BatcherRequest, BatcherResponse>; pub fn create_batcher_server(
Suggestion:
create_local_batcher_server
commit-id:96eb0ab9
d4c69b7
to
dd9ca10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry)
crates/batcher/src/communication.rs
line 16 at r1 (raw file):
use crate::batcher::Batcher; pub type BatcherServer = LocalComponentServer<Batcher, BatcherRequest, BatcherResponse>;
Done.
crates/batcher/src/communication.rs
line 20 at r1 (raw file):
pub type RemoteBatcherServer = RemoteComponentServer<Batcher, BatcherRequest, BatcherResponse>; pub fn create_batcher_server(
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
commit-id:96eb0ab9
This change is