Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batcher): move build_block parameter into the block_builder object #1929

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Yael-Starkware commented Nov 10, 2024

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 3.69%. Comparing base (e3165c4) to head (525bf6b).
Report is 307 commits behind head on main.

Files with missing lines Patch % Lines
crates/batcher/src/block_builder.rs 60.60% 12 Missing and 1 partial ⚠️
crates/batcher/src/proposal_manager.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1929       +/-   ##
==========================================
- Coverage   40.10%   3.69%   -36.42%     
==========================================
  Files          26     140      +114     
  Lines        1895   17031    +15136     
  Branches     1895   17031    +15136     
==========================================
- Hits          760     629      -131     
- Misses       1100   16359    +15259     
- Partials       35      43        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware force-pushed the yael/add_validate_support_to_build_block branch from c35f56a to 2c85534 Compare November 11, 2024 10:47
@Yael-Starkware Yael-Starkware changed the base branch from yael/add_validate_support_to_build_block to graphite-base/1929 November 11, 2024 12:29
@Yael-Starkware Yael-Starkware force-pushed the 11-10-refactor_batcher_move_build_block_parameter_into_the_block_builder_object branch from 94c82fa to 525bf6b Compare November 11, 2024 14:01
@Yael-Starkware Yael-Starkware changed the base branch from graphite-base/1929 to main November 11, 2024 14:01
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware merged commit f5917a3 into main Nov 11, 2024
12 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants