-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): enforce workspace lints in crate tomls #1922
feat(ci): enforce workspace lints in crate tomls #1922
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
===========================================
+ Coverage 40.10% 85.24% +45.14%
===========================================
Files 26 3 -23
Lines 1895 122 -1773
Branches 1895 122 -1773
===========================================
- Hits 760 104 -656
+ Misses 1100 14 -1086
+ Partials 35 4 -31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
workspace_tests/lints_test.rs
line 15 at r1 (raw file):
assert!( crates_without_lints.is_empty(), "The following crates are missing a [lints] section: {crates_without_lints:?}."
More prty, also below
Suggestion:
"The following crates are missing a [lints] section: {crates_without_lints:#?}."
workspace_tests/version_integrity_test.rs
line 36 at r1 (raw file):
let crate_paths: Vec<String> = crate_cargo_toml.path_dependencies().collect(); all_path_deps_in_crate_tomls.extend(crate_paths); }
maybe
Suggestion:
ROOT_TOML
.member_cargo_tomls()
.values()
.flat_map(|toml| toml.path_dependencies())
.collect()
workspace_tests/toml_utils.rs
line 89 at r1 (raw file):
.iter() .map(|member| { let cargo_toml_path = Path::new(&crates_dir).join(member).join("Cargo.toml");
Path is a slice
Suggestion:
let crates_dir = Path::new(concat!(env!("CARGO_MANIFEST_DIR"), "/../"));
self.members()
.iter()
.map(|member| {
let cargo_toml_path = crates_dir.join(member).join("Cargo.toml");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Signed-off-by: Dori Medini <[email protected]>
3886137
to
dbedf35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.