Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests-integration): wrap integration test setup in a struct #1913

Closed
wants to merge 1 commit into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 10, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.59%. Comparing base (32a7d71) to head (ca9a97b).

Additional details and impacted files
@@                Coverage Diff                 @@
##           spr/main/6218b7d0    #1913   +/-   ##
==================================================
  Coverage              29.59%   29.59%           
==================================================
  Files                    266      266           
  Lines                  31100    31100           
  Branches               31100    31100           
==================================================
  Hits                    9203     9203           
  Misses                 21005    21005           
  Partials                 892      892           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #1915

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants