Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename mempool infra crate #1909

Merged
merged 5 commits into from
Nov 10, 2024
Merged

chore: rename mempool infra crate #1909

merged 5 commits into from
Nov 10, 2024

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 10, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.74%. Comparing base (e3165c4) to head (9c62a6b).
Report is 280 commits behind head on main.

Files with missing lines Patch % Lines
crates/sequencer_node/src/servers.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1909       +/-   ##
===========================================
+ Coverage   40.10%   76.74%   +36.64%     
===========================================
  Files          26      369      +343     
  Lines        1895    39271    +37376     
  Branches     1895    39271    +37376     
===========================================
+ Hits          760    30139    +29379     
- Misses       1100     6871     +5771     
- Partials       35     2261     +2226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/e6d147ee to main November 10, 2024 14:10
@nadin-Starkware nadin-Starkware merged commit 377045e into main Nov 10, 2024
22 checks passed
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.759 ms 34.810 ms 34.878 ms]
change: [+1.2906% +1.5971% +1.8827%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants