Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): add support for native testing #1883

Closed

Conversation

noaov1
Copy link
Collaborator

@noaov1 noaov1 commented Nov 7, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@noaov1 noaov1 force-pushed the noa/update_testing_to_support_native branch from 8361bc7 to e50a5e5 Compare November 7, 2024 17:22
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.52%. Comparing base (48fdf7a) to head (12e4587).
Report is 1 commits behind head on rdr/update-testing-suite.

Files with missing lines Patch % Lines
crates/blockifier/src/test_utils/cairo_compile.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           rdr/update-testing-suite    #1883      +/-   ##
============================================================
+ Coverage                     46.40%   46.52%   +0.11%     
============================================================
  Files                           277      280       +3     
  Lines                         31554    31463      -91     
  Branches                      31554    31463      -91     
============================================================
- Hits                          14643    14637       -6     
+ Misses                        15901    15819      -82     
+ Partials                       1010     1007       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noaov1 noaov1 force-pushed the noa/update_testing_to_support_native branch from e50a5e5 to f3e5b4e Compare November 7, 2024 17:43
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@noaov1 noaov1 force-pushed the noa/update_testing_to_support_native branch from f3e5b4e to ad27674 Compare November 7, 2024 17:51
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@noaov1 noaov1 force-pushed the noa/update_testing_to_support_native branch from ad27674 to 61a06a9 Compare November 7, 2024 18:39
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 7, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.551 ms 33.579 ms 33.610 ms]
change: [-4.4752% -2.9189% -1.5397%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [29.674 ms 29.723 ms 29.771 ms]
change: [+1.1375% +1.3878% +1.6257%] (p = 0.00 < 0.05)
Performance has regressed.

@noaov1 noaov1 force-pushed the noa/update_testing_to_support_native branch from 61a06a9 to b333c44 Compare November 7, 2024 18:56
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@noaov1 noaov1 force-pushed the noa/update_testing_to_support_native branch from b333c44 to 12e4587 Compare November 7, 2024 19:12
Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@rodrigo-pino rodrigo-pino added the native integration Related with the integration of Cairo Native into the Blockifier label Nov 9, 2024
@rodrigo-pino
Copy link
Contributor

Closing since it has been merged tordr/update-testing-suit (#1301)

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants