chore(blockifier): update cairo version to 2.9.0 #1854
Conversation
|
This change is |
|
Artifacts upload triggered. View details here |
|
Benchmark movements: full_committer_flow performance regressed! |
varex83
added
the
native integration
|
Artifacts upload triggered. View details here |
|
Benchmark movements: |
|
Artifacts upload triggered. View details here |
PearsonWhite
force-pushed
the
pwhite/cairo_2.9.0
branch
from
275a9d7
to
2285a95
Compare
|
Artifacts upload triggered. View details here |
|
Benchmark movements: |
|
Artifacts upload triggered. View details here |
|
Benchmark movements: full_committer_flow performance regressed! |
PearsonWhite
force-pushed
the
pwhite/cairo_2.9.0
branch
from
c9b7d75
to
8ac7de6
Compare
|
Artifacts upload triggered. View details here |
|
Benchmark movements: full_committer_flow performance regressed! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1854 +/- ##
===========================================
+ Coverage 40.10% 76.91% +36.80%
===========================================
Files 26 365 +339
Lines 1895 39131 +37236
Branches 1895 39131 +37236
===========================================
+ Hits 760 30096 +29336
- Misses 1100 6779 +5679
- Partials 35 2256 +2221 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1.
Reviewable status: 17 of 24 files reviewed, 1 unresolved discussion (waiting on @meship-starkware, @noaov1, and @PearsonWhite)
crates/blockifier/src/transaction/transactions_test.rs line 2298 at r1 (raw file):
+ 6, ), (BuiltinName::pedersen, 11 + payload_size),
Is there a reason for this reordering? Or is it just the formatter?
Code quote:
(
BuiltinName::range_check,
get_tx_resources(TransactionType::L1Handler).builtin_instance_counter
[&BuiltinName::range_check]
+ 6,
),
(BuiltinName::pedersen, 11 + payload_size),
There was a problem hiding this comment.
Reviewed 4 of 17 files at r1.
Reviewable status: 17 of 24 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @PearsonWhite)
There was a problem hiding this comment.
Reviewed 11 of 17 files at r1.
Reviewable status: 17 of 24 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @PearsonWhite)
There was a problem hiding this comment.
Reviewed 2 of 17 files at r1, 3 of 7 files at r2, all commit messages.
Reviewable status: 20 of 24 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @PearsonWhite)
crates/gateway/src/rpc_state_reader_test.rs line 167 at r2 (raw file):
hints: Default::default(), pythonic_hints: Default::default(), entry_points_by_type: Default::default(),
Why can't you use ..Default::default()?
Code quote:
compiler_version: "0.0.0".to_string(),
prime: Default::default(),
bytecode: Default::default(),
bytecode_segment_lengths: Default::default(),
hints: Default::default(),
pythonic_hints: Default::default(),
entry_points_by_type: Default::default(),
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @PearsonWhite)
Cargo.toml line 99 at r2 (raw file):
cairo-lang-starknet-classes = "2.9.0-dev.0" cairo-lang-utils = "2.9.0-dev.0" # Important: when updated, make sure to update the cairo-native submodule as well.
Can you please update the git submodel?
Code quote:
# Important: when updated, make sure to update the cairo-native submodule as well.crates/blockifier/src/execution/syscalls/syscall_tests/sha256.rs line 1 at r2 (raw file):
use pretty_assertions::assert_eq;
Why is it needed now?
Code quote:
use pretty_assertions::assert_eq;crates/gateway/src/rpc_state_reader_test.rs line 168 at r2 (raw file):
pythonic_hints: Default::default(), entry_points_by_type: Default::default(), };
What is the reason for this change?
Code quote:
prime: Default::default(),
bytecode: Default::default(),
bytecode_segment_lengths: Default::default(),
hints: Default::default(),
pythonic_hints: Default::default(),
entry_points_by_type: Default::default(),
};
PearsonWhite
force-pushed
the
pwhite/cairo_2.9.0
branch
from
8ac7de6
to
e9f230c
Compare
|
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Reviewed 2 of 9 files at r4, all commit messages.
Reviewable status: 18 of 25 files reviewed, 4 unresolved discussions (waiting on @meship-starkware and @PearsonWhite)
PearsonWhite
force-pushed
the
pwhite/cairo_2.9.0
branch
from
e9f230c
to
9405770
Compare
|
Artifacts upload triggered. View details here |
PearsonWhite
force-pushed
the
pwhite/cairo_2.9.0
branch
from
9405770
to
764ceb4
Compare
|
Artifacts upload triggered. View details here |
|
Benchmark movements: full_committer_flow performance regressed! |
There was a problem hiding this comment.
Reviewable status: 17 of 25 files reviewed, 4 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @noaov1)
Cargo.toml line 99 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Can you please update the git submodel?
Updated.
crates/blockifier/src/execution/syscalls/syscall_tests/sha256.rs line 1 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Why is it needed now?
Removed.
crates/blockifier/src/transaction/transactions_test.rs line 2298 at r1 (raw file):
Previously, avi-starkware wrote…
Is there a reason for this reordering? Or is it just the formatter?
I thought this was causing a test failure, but it wasn't. Reverted back.
crates/gateway/src/rpc_state_reader_test.rs line 167 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Why can't you use ..Default::default()?
CasmContractClass::Default was removed from cairo in this PR: starkware-libs/cairo#6383
crates/gateway/src/rpc_state_reader_test.rs line 168 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
What is the reason for this change?
CasmContractClass::Default was removed from cairo in this PR: starkware-libs/cairo#6383
There was a problem hiding this comment.
Reviewed 9 of 9 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avi-starkware and @noaov1)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)
There was a problem hiding this comment.
Reviewed 6 of 9 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @PearsonWhite)
No description provided.