refactor(sync): move non fatal errors from P2PSyncClientError to BadPeerError #1822
+82
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
noamsp-starkware
changed the title
noamsp-starkware
force-pushed
the
noam.s/light_verifications_inside_sync_2
branch
from
07bdb1d
to
cfe3d0d
Compare
noamsp-starkware
force-pushed
the
noam.s/light_verifications_inside_sync_2
branch
from
cfe3d0d
to
7d0efad
Compare
noamsp-starkware
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## noam.s/light_verifications_inside_sync_1 #1822 +/- ##
=========================================================================
Coverage 18.63% 18.63%
=========================================================================
Files 100 100
Lines 12220 12216 -4
Branches 12220 12216 -4
=========================================================================
Hits 2277 2277
+ Misses 9516 9509 -7
- Partials 427 430 +3 ☔ View full report in Codecov by Sentry. |
ShahakShama
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
moves non-fatal state diff related errors to BadPeerError to allow retrying the query with a different peer. previously state diff related tests checked these non-fatal errors as assertions to certain scenarios. we now just check that these scenarios cause peer reporting.
noamsp-starkware
merged commit da56660
into
noam.s/light_verifications_inside_sync_1
14 of 15 checks passed
noamsp-starkware
deleted the
noam.s/light_verifications_inside_sync_2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.