feat(blockifier): add get_execution_info_v1 syscall

[varex83]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.56%. Comparing base (e3165c4) to head (5a84c46).
Report is 357 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/transaction/objects.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1735       +/-   ##
===========================================
+ Coverage   40.10%   67.56%   +27.45%     
===========================================
  Files          26      103       +77     
  Lines        1895    13851    +11956     
  Branches     1895    13851    +11956     
===========================================
+ Hits          760     9358     +8598     
- Misses       1100     4093     +2993     
- Partials       35      400      +365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 2 of 6 files at r1, all commit messages.
Reviewable status: 2 of 6 files reviewed, all discussions resolved (waiting on @noaov1)

[meship-starkware]

Reviewed 4 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 267 at r1 (raw file):

    let word_in_hex: String =
        s.as_bytes().iter().fold(String::new(), |s, byte| s + (&format!("{:02x}", byte)));
    [prefix, &padding_zeros, &word_in_hex].into_iter().collect()

Why did you remove this test?

Code quote:

#[test]
fn test_gas_types_constants() {
    assert_eq!(str_to_32_bytes_in_hex("L1_GAS"), Resource::L1Gas.to_hex());
    assert_eq!(str_to_32_bytes_in_hex("L2_GAS"), Resource::L2Gas.to_hex());
    assert_eq!(str_to_32_bytes_in_hex("L1_DATA"), Resource::L1DataGas.to_hex());
}

fn str_to_32_bytes_in_hex(s: &str) -> String {
    if s.len() > 32 {
        panic!("Unsupported input of length > 32.")
    }
    let prefix = "0x";
    let padding_zeros = "0".repeat(64 - s.len() * 2); // Each string char is 2 chars in hex.
    let word_in_hex: String =
        s.as_bytes().iter().fold(String::new(), |s, byte| s + (&format!("{:02x}", byte)));
    [prefix, &padding_zeros, &word_in_hex].into_iter().collect()

---

crates/blockifier/src/transaction/objects.rs line 92 at r1 (raw file):

    pub fn max_fee(&self) -> TransactionFeeResult<Fee> {
        match self {
            Self::Current(_context) => Ok(Fee(0)),

Suggestion:

Self::Current(_) => Ok(Fee(0)),

[meship-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/transaction/objects.rs line 90 at r1 (raw file):

    }

    pub fn max_fee(&self) -> TransactionFeeResult<Fee> {

Why are you returning a result? Where can it fail?

Code quote:

TransactionFeeResult

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[varex83]

Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 267 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Why did you remove this test?

Done

Most likely some rebasing problems 👀

---

crates/blockifier/src/transaction/objects.rs line 90 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Why are you returning a result? Where can it fail?

Done

---

crates/blockifier/src/transaction/objects.rs line 92 at r1 (raw file):

    pub fn max_fee(&self) -> TransactionFeeResult<Fee> {
        match self {
            Self::Current(_context) => Ok(Fee(0)),

Done

[meship-starkware]

Reviewed 1 of 4 files at r2.
Reviewable status: 3 of 6 files reviewed, all discussions resolved (waiting on @noaov1)

[meship-starkware]

Reviewed 3 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware)