Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow StreamHandler to use a generic StreamId #1714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guy-starkware
Copy link
Contributor

The stream ID is used to uniquely separate streams coming from the same peer. In the use case of consensus, this can be the (height, round) we are in.

In general, the stream_id should be convertible into a Vec<u8>> and should have some other traits like Display and Clone, etc.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.24%. Comparing base (e3165c4) to head (24e0581).
Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
...sequencing/papyrus_consensus/src/stream_handler.rs 92.10% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
+ Coverage   40.10%   46.24%   +6.13%     
==========================================
  Files          26       84      +58     
  Lines        1895    10134    +8239     
  Branches     1895    10134    +8239     
==========================================
+ Hits          760     4686    +3926     
- Misses       1100     5063    +3963     
- Partials       35      385     +350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guy-starkware guy-starkware force-pushed the guyn/streams/generic_stream_id branch 2 times, most recently from 24e0581 to 506ed06 Compare November 3, 2024 14:12
Copy link

github-actions bot commented Dec 4, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 4, 2024
@github-actions github-actions bot closed this Dec 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@guy-starkware guy-starkware reopened this Dec 19, 2024
@guy-starkware guy-starkware force-pushed the guyn/streams/generic_stream_id branch from 506ed06 to 69d1bac Compare December 25, 2024 09:27
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware force-pushed the guyn/streams/generic_stream_id branch from 69d1bac to 20b5d1b Compare December 25, 2024 11:58
@guy-starkware guy-starkware force-pushed the guyn/streams/generic_stream_id branch from 20b5d1b to 0c03a4e Compare December 25, 2024 12:16
@guy-starkware guy-starkware reopened this Dec 25, 2024
@starkware-libs starkware-libs unlocked this conversation Dec 25, 2024
Copy link

Artifacts upload workflows:

@github-actions github-actions bot removed the stale label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants