-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow StreamHandler to use a generic StreamId #1714
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
==========================================
+ Coverage 40.10% 46.24% +6.13%
==========================================
Files 26 84 +58
Lines 1895 10134 +8239
Branches 1895 10134 +8239
==========================================
+ Hits 760 4686 +3926
- Misses 1100 5063 +3963
- Partials 35 385 +350 ☔ View full report in Codecov by Sentry. |
24e0581
to
506ed06
Compare
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
506ed06
to
69d1bac
Compare
69d1bac
to
20b5d1b
Compare
20b5d1b
to
0c03a4e
Compare
Artifacts upload workflows: |
The stream ID is used to uniquely separate streams coming from the same peer. In the use case of consensus, this can be the
(height, round)
we are in.In general, the
stream_id
should be convertible into aVec<u8>>
and should have some other traits likeDisplay
andClone
, etc.