-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(batcher): remove the duplicated papyrus_reader from native_blockifier #1640
chore(batcher): remove the duplicated papyrus_reader from native_blockifier #1640
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Yael-Starkware and the rest of your teammates on Graphite |
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes this PRS contains:
- papyrus_reader was deleted from native_blockifier (since it was previously duplicated to the batcher).
- native_blockifier now uses papyrus_reader from the batcher.
- papyrus_reader_test was split. It had 2 tests: one of them went to the batcher , and the other to py_block_executor_test - since it only used py_block_executor functionality.
- large_compiled_contract.json moved to a new native_blockifier/resources directory.
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @alonh5 and @noaov1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
===========================================
+ Coverage 40.10% 76.99% +36.89%
===========================================
Files 26 364 +338
Lines 1895 39076 +37181
Branches 1895 39076 +37181
===========================================
+ Hits 760 30087 +29327
- Misses 1100 6744 +5644
- Partials 35 2245 +2210 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @Yoni-Starkware)
0baca0e
to
86381a9
Compare
Artifacts upload triggered. View details here |
86381a9
to
d656afd
Compare
Artifacts upload triggered. View details here |
d656afd
to
3a52537
Compare
Artifacts upload triggered. View details here |
3a52537
to
ae860ba
Compare
Artifacts upload triggered. View details here |
ae860ba
to
ea4d1b8
Compare
Artifacts upload triggered. View details here |
ea4d1b8
to
d46f799
Compare
Artifacts upload triggered. View details here |
d46f799
to
8b3e9bc
Compare
Artifacts upload triggered. View details here |
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 10 files at r1, 8 of 12 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
No description provided.