Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batcher): remove the duplicated papyrus_reader from native_blockifier #1640

Merged

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Yael-Starkware and the rest of your teammates on Graphite Graphite

Copy link

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware marked this pull request as ready for review October 29, 2024 08:46
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes this PRS contains:

  1. papyrus_reader was deleted from native_blockifier (since it was previously duplicated to the batcher).
  2. native_blockifier now uses papyrus_reader from the batcher.
  3. papyrus_reader_test was split. It had 2 tests: one of them went to the batcher , and the other to py_block_executor_test - since it only used py_block_executor functionality.
  4. large_compiled_contract.json moved to a new native_blockifier/resources directory.

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @alonh5 and @noaov1)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.99%. Comparing base (e3165c4) to head (8b3e9bc).
Report is 290 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1640       +/-   ##
===========================================
+ Coverage   40.10%   76.99%   +36.89%     
===========================================
  Files          26      364      +338     
  Lines        1895    39076    +37181     
  Branches     1895    39076    +37181     
===========================================
+ Hits          760    30087    +29327     
- Misses       1100     6744     +5644     
- Partials       35     2245     +2210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @Yoni-Starkware)

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from 0baca0e to 86381a9 Compare November 4, 2024 09:59
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from 86381a9 to d656afd Compare November 4, 2024 10:08
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from d656afd to 3a52537 Compare November 4, 2024 10:12
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from 3a52537 to ae860ba Compare November 4, 2024 10:13
Copy link

github-actions bot commented Nov 4, 2024

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from ae860ba to ea4d1b8 Compare November 5, 2024 09:12
Copy link

github-actions bot commented Nov 5, 2024

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from ea4d1b8 to d46f799 Compare November 10, 2024 06:58
Copy link

Artifacts upload triggered. View details here

@Yael-Starkware Yael-Starkware force-pushed the yael/remove_papyrus_reader_from_native_blockifier branch from d46f799 to 8b3e9bc Compare November 10, 2024 07:07
Copy link

Artifacts upload triggered. View details here

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.896 ms 33.947 ms 34.004 ms]
change: [-3.5763% -2.3104% -1.2792%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 10 files at r1, 8 of 12 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@Yael-Starkware Yael-Starkware merged commit b02f45b into main Nov 11, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants