chore(consensus): remove irrelevant TODO items

starkware-libs · Dec 22, 2024 · f936f3e · f936f3e
1 parent 0977142
commit f936f3e
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 6 deletions.
diff --git a/crates/papyrus_protobuf/Cargo.toml b/crates/papyrus_protobuf/Cargo.toml
@@ -9,7 +9,6 @@ license-file.workspace = true
 testing = ["papyrus_test_utils", "rand", "rand_chacha"]
 
 [dependencies]
-# TODO(Guy): Remove after implementing broadcast streams.
 indexmap.workspace = true
 lazy_static.workspace = true
 primitive-types.workspace = true

diff --git a/crates/papyrus_protobuf/src/consensus.rs b/crates/papyrus_protobuf/src/consensus.rs
@@ -113,7 +113,6 @@ where
     T: Clone + Into<Vec<u8>> + TryFrom<Vec<u8>, Error = ProtobufConversionError>,
 {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        // TODO(guyn): add option to display when message is Fin and doesn't have content (PR #1048)
         if let StreamMessageBody::Content(message) = &self.message {
             let message: Vec<u8> = message.clone().into();
             write!(

diff --git a/crates/sequencing/papyrus_consensus/src/manager_test.rs b/crates/sequencing/papyrus_consensus/src/manager_test.rs
@@ -83,7 +83,6 @@ async fn manager_multiple_heights_unordered() {
         mock_register_broadcast_topic().unwrap();
     let mut sender = mock_network.broadcasted_messages_sender;
 
-    // TODO(guyn): refactor this test to pass proposals through the correct channels.
     let (mut proposal_receiver_sender, mut proposal_receiver_receiver) =
         mpsc::channel(CHANNEL_SIZE);
 
@@ -149,7 +148,6 @@ async fn run_consensus_sync() {
     let mut context = MockTestContext::new();
     let (decision_tx, decision_rx) = oneshot::channel();
 
-    // TODO(guyn): refactor this test to pass proposals through the correct channels.
     let (mut proposal_receiver_sender, proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE);
 
     expect_validate_proposal(&mut context, Felt::TWO);
@@ -214,7 +212,6 @@ async fn run_consensus_sync_cancellation_safety() {
     let proposal_handled = Arc::new(Notify::new());
     let (decision_tx, decision_rx) = oneshot::channel();
 
-    // TODO(guyn): refactor this test to pass proposals through the correct channels.
     let (mut proposal_receiver_sender, proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE);
 
     expect_validate_proposal(&mut context, Felt::ONE);
@@ -287,7 +284,6 @@ async fn test_timeouts() {
         mock_register_broadcast_topic().unwrap();
     let mut sender = mock_network.broadcasted_messages_sender;
 
-    // TODO(guyn): refactor this test to pass proposals through the correct channels.
     let (mut proposal_receiver_sender, mut proposal_receiver_receiver) =
         mpsc::channel(CHANNEL_SIZE);