Skip to content

Commit

Permalink
Revert "feat(ci): add native dependencies to the CI (dynamic docker) (#…
Browse files Browse the repository at this point in the history
…726)" (#864)

* Revert "feat(ci): add native dependencies to the CI (dynamic docker) (#726)"

This reverts commit c1f680a.

* fix: update compiler version in compiled feature contracts and fix gas
  • Loading branch information
noaov1 authored Sep 19, 2024
1 parent 83bc16a commit ac56ada
Show file tree
Hide file tree
Showing 26 changed files with 87 additions and 734 deletions.
28 changes: 0 additions & 28 deletions .github/actions/setup-native-deps/action.yml

This file was deleted.

12 changes: 7 additions & 5 deletions .github/workflows/blockifier_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,19 @@ jobs:
- uses: Swatinem/rust-cache@v2
with:
prefix-key: "v0-rust-ubuntu-20.04"
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- run: cargo build -p blockifier
- run: cargo test -p blockifier

native-blockifier-artifacts-push:
runs-on: starkware-ubuntu-latest-large
runs-on: starkware-ubuntu-20-04-medium
steps:
- uses: actions/checkout@v4

- uses: ./.github/actions/install_rust

- uses: Swatinem/rust-cache@v2
with:
prefix-key: "v1-rust-ubuntu-20.04"

- name: Build native blockifier
run: ./build_native_in_docker.sh scripts/build_native_blockifier.sh

Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/blockifier_compiled_cairo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ jobs:
with:
prefix-key: "v0-rust-ubuntu-20.04"

- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps

# Setup pypy and link to the location expected by .cargo/config.toml.
- uses: actions/setup-python@v5
id: setup-pypy
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/blockifier_post-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ jobs:
with:
prefix-key: "v0-rust-ubuntu-20.04"

- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps

# Setup pypy and link to the location expected by .cargo/config.toml.
- uses: actions/setup-python@v5
id: setup-pypy
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/committer_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:

# List the existing benchmarks.
- run: |
cargo bench -p committer_cli -- --list | grep ': benchmark$' | sed -e "s/: benchmark$//" > benchmarks_list.txt
cargo bench -p committer_cli -- --list | grep ': benchmark$' | sed -e "s/: benchmark$//" > benchmarks_list.txt
# Benchmark the old code.
- run: cargo bench -p committer_cli
Expand Down Expand Up @@ -119,7 +119,6 @@ jobs:
owner: context.repo.owner,
repo: context.repo.repo,
body: fs.readFileSync('bench_new.txt', 'utf8'),
path: 'Commits'
})
gcs-push:
Expand Down
26 changes: 3 additions & 23 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,6 @@ jobs:
- uses: ./.github/actions/install_rust
with:
components: clippy

- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps

- uses: Swatinem/rust-cache@v2
with:
prefix-key: "v0-rust-ubuntu-20.04"
Expand All @@ -94,9 +89,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Swatinem/rust-cache@v2
- uses: Noelware/[email protected]
with:
Expand All @@ -108,23 +100,17 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Swatinem/rust-cache@v2
- run: cargo test -p workspace_tests

run-tests:
runs-on: starkware-ubuntu-latest-large
runs-on: starkware-ubuntu-20-04-medium
steps:
- uses: actions/checkout@v4
with:
# Fetch the entire history.
fetch-depth: 0
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Noelware/[email protected]
- uses: Swatinem/rust-cache@v2
with:
Expand Down Expand Up @@ -189,9 +175,6 @@ jobs:
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- run: cargo check --workspace -r --all-features

merge-gatekeeper:
Expand All @@ -207,7 +190,7 @@ jobs:
uses: upsidr/merge-gatekeeper@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
timeout: 1500
timeout: 1200
interval: 30
ignored: "code-review/reviewable"

Expand All @@ -217,7 +200,7 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
ref: ${{github.ref}}
timeout: 1500
timeout: 1200
interval: 30
ignored: "code-review/reviewable"

Expand All @@ -233,9 +216,6 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install -y clang llvm libudev-dev
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/papyrus_benchmark.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
# TODO: Uncomment and run this automatically when the storage benchmark is fixed.
# push:
# branches: [main]
# branches: [main]

jobs:
storage-benchmark:
Expand Down
26 changes: 3 additions & 23 deletions .github/workflows/papyrus_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Papyrus-CI

on:
push:
branches: [ main ]
branches: [main]
paths:
- '.github/workflows/papyrus_ci.yml'
- 'Dockerfile'
Expand Down Expand Up @@ -31,7 +31,7 @@ on:
- 'crates/starknet_client/**'

merge_group:
types: [ checks_requested ]
types: [checks_requested]

# On PR events, cancel existing CI runs on this same PR for this workflow.
concurrency:
Expand All @@ -48,9 +48,6 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- uses: Swatinem/rust-cache@v2
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
Expand All @@ -70,9 +67,6 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- uses: Swatinem/rust-cache@v2
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
Expand All @@ -92,9 +86,6 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
Expand All @@ -116,9 +107,6 @@ jobs:
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- run: >
cargo test -r
--test latency_histogram
Expand All @@ -134,9 +122,6 @@ jobs:
- uses: ./.github/actions/install_rust
- uses: Swatinem/rust-cache@v2
- uses: Noelware/[email protected]
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps

- run: |
cargo test -p papyrus_node --no-default-features
Expand All @@ -155,9 +140,7 @@ jobs:
- uses: Noelware/[email protected]
with:
version: ${{env.PROTOC_VERSION}}
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps

- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
- uses: Swatinem/rust-cache@v2
Expand Down Expand Up @@ -214,9 +197,6 @@ jobs:
target_directory:
- 'crates/papyrus_storage/src/db/**'
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Swatinem/rust-cache@v2
# repeat this job 32 times. this is a random test for part of the code that may cause a corrupted database.
- run: for run in {1..32}; do cargo test -r -p papyrus_storage -- --include-ignored common_prefix_compare_with_simple_table_random; done
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/papyrus_docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: Papyrus-Docker-Publish
on:
workflow_dispatch:
push:
branches: [ main ]
tags: [ "v*.*.*" ]
branches: [main]
tags: ["v*.*.*"]
paths:
- '.github/workflows/papyrus_docker-publish.yml'
- 'crates/papyrus**/**'
Expand All @@ -25,7 +25,7 @@ env:

jobs:
docker-build-push:
runs-on: starkware-ubuntu-latest-large
runs-on: starkware-ubuntu-latest-medium

steps:
- name: Checkout repository
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/papyrus_nightly-tests-call.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Swatinem/rust-cache@v2
- run: sudo apt update; sudo apt -y install libclang-dev
# Install libclang-dev that is not a part of the ubuntu vm in github actions.
Expand Down
16 changes: 0 additions & 16 deletions .github/workflows/papyrus_nightly-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ jobs:

- run: brew install protobuf@$PROTOC_VERSION

- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps

- name: Build node
run: cargo build -r -p papyrus_node

Expand All @@ -62,9 +58,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- uses: Swatinem/rust-cache@v2
- run: npm install -g [email protected]

Expand All @@ -82,9 +75,6 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- uses: Swatinem/rust-cache@v2
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- run: cargo build -r -p papyrus_load_test

integration-test:
Expand All @@ -94,9 +84,6 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- uses: Swatinem/rust-cache@v2
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- run: >
cargo test -r
--test latency_histogram
Expand All @@ -113,7 +100,4 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- uses: Swatinem/rust-cache@v2
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- run: for run in {1..100}; do cargo test -r -p papyrus_storage -- --include-ignored common_prefix_compare_with_simple_table_random; done
3 changes: 0 additions & 3 deletions .github/workflows/verify-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
- name: Set up Native Dependencies
uses: ./.github/actions/setup-native-deps
id: native-deps
- name: Update Dependencies
run: cargo update --verbose
- name: Build
Expand Down
Loading

0 comments on commit ac56ada

Please sign in to comment.