Skip to content

Commit

Permalink
chore: make sure that the cairo_native flag works in python (#2465)
Browse files Browse the repository at this point in the history
  • Loading branch information
meship-starkware authored Dec 10, 2024
1 parent e90e447 commit 036bbc0
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 6 deletions.
4 changes: 4 additions & 0 deletions .github/actions/bootstrap/action.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
runs:
using: "composite"
steps:
# required to clone native as a gitsubmodule
- name: Submodules update.
run: git submodule update --init --recursive
shell: bash
- name: Install rust.
uses: ./.github/actions/install_rust
- name: Install cairo native.
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/blockifier_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
# required to clone native as a gitsubmodule
submodules: recursive
fetch-depth: 0
- uses: ./.github/actions/bootstrap
# No features - build blockifier without features activated by dependencies in the workspace.
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ jobs:
# Environment setup.
- uses: actions/checkout@v4
with:
# required to clone native as a git submodule
submodules: recursive
# Fetch the entire history. Required to checkout the merge target commit, so the diff can
# be computed.
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload_artifacts_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:

jobs:
native-blockifier-artifacts-push:
runs-on: starkware-ubuntu-20-04-medium
runs-on: starkware-ubuntu-latest-medium
steps:
- name: Get commit hash prefix for PR update
env:
Expand Down
2 changes: 1 addition & 1 deletion crates/native_blockifier/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ crate-type = ["cdylib"]

[dependencies]
# TODO(Dori, 1/1/2025): Add the "jemalloc" feature to the blockifier crate when possible.
blockifier = { workspace = true, features = ["testing"] }
blockifier = { workspace = true, features = ["cairo_native", "testing"] }
cairo-lang-starknet-classes.workspace = true
cairo-vm.workspace = true
indexmap.workspace = true
Expand Down
5 changes: 5 additions & 0 deletions scripts/build_native_blockifier.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ function clean() {
rm -rf venv || true
}

function init_submodule() {
echo "Initializing submodule..."
git submodule update --init --recursive
}

function build() {
echo "Building..."
Expand All @@ -16,4 +20,5 @@ function build() {
clean
}

init_submodule &&
build

0 comments on commit 036bbc0

Please sign in to comment.