Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): support loadbalancer static ip #2252

Closed
wants to merge 2 commits into from
Closed

feat(helm): support loadbalancer static ip #2252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daf4c07
feat(helm): support loadbalancer static ip and p2p service annotations
idan-starkware Jul 28, 2024
1a77f99
fix(helm): fixed annotations condition and indent
idan-starkware Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployments/helm/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
annotations:
{{- if .Values.deployment.annotations }}
{{ toYaml .Values.deployment.annotations | nindent 8 }}
{{- end}}
{{- end }}
{{- if .Values.service.ports.monitoring.enabled }}
prometheus.io/scrape: "true"
prometheus.io/path: "/monitoring/metrics"
Expand Down
7 changes: 7 additions & 0 deletions deployments/helm/templates/p2p-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,17 @@ metadata:
name: {{ template "papyrus.name" . }}-p2p
labels:
{{- include "papyrus.labels" . | nindent 4 }}
annotations:
{{- if .Values.p2p.service.annotations }}
{{ toYaml .Values.p2p.service.annotations | nindent 4 }}
{{- end}}
spec:
selector:
{{- include "papyrus.selectorLabels" . | nindent 6 }}
type: {{ .Values.p2p.service.type }}
{{- if and (eq .Values.p2p.service.type "LoadBalancer") .Values.p2p.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.p2p.service.loadBalancerIP }}
{{- end }}
ports:
- name: p2p
port: {{ .Values.p2p.service.port }}
Expand Down
2 changes: 1 addition & 1 deletion deployments/helm/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
{{- include "papyrus.labels" . | nindent 4 }}
spec:
selector:
{{- include "papyrus.selectorLabels" . | nindent 6 }}
{{- include "papyrus.selectorLabels" . | nindent 4 }}
type: {{ .Values.service.type }}
ports:
{{- if and .Values.service.ports.rpc .Values.service.ports.rpc.enabled }}
Expand Down
2 changes: 2 additions & 0 deletions deployments/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ p2p:
type: ClusterIP
port: 10000
protocol: TCP
loadBalancerIP:
annotations: {}

deployment:
# The container image
Expand Down
Loading