feat(profiler): allow to preserve original stack trace order #6441
Conversation
m-kus
force-pushed
the
feat/profiler-ordered-stack-trace
branch
4 times, most recently
from
d9a7e0e to
6401512
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @m-kus)
m-kus
force-pushed
the
feat/profiler-ordered-stack-trace
branch
from
6401512 to
1e5f389
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @m-kus)
a discussion (no related file):
why is this required?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
a discussion (no related file):
Previously, orizi wrote…
why is this required?
It is useful to be able to iterate through the stack trace in the execution order both for troubleshooting and post-processing purposes. In particular I need this to be able to collapse loops (and recursive calls in general) which make flame charts hard to analyze.
If you mean the most recent push, that was clippy fix + rebase.
There was a problem hiding this comment.
Reviewable status:
This PR allows to preserve the original order of the stack trace as opposed to the current approach when items are sorted by weight (and stack entry).
Backwards compatible.
This change is