LS: Refactor get_uri into LsProtoGroup::url_for_file
#5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2024
orizi
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mkaput)
orizi
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Reviewable status:
commit-id:fade1eda
mkaput
force-pushed
the
spr/main/fade1eda
branch
from
2f76fb4 to
93c7f02
Compare
shramee
pushed a commit
to shramee/cairo
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
get_diagnosticsout of the main module #5316from_posout of the main module #5315get_uriintoLsProtoGroup::url_for_file#5314 ⬅This change is