Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize sierra version to int not string #4252

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

maciektr
Copy link
Collaborator

@maciektr maciektr commented Oct 12, 2023

Serialize sierra version field to int instead of string (i.e. version = 1 instead of version = "1".
For context on serde side see: serde-rs/serde#745

This change is Reviewable

@mkaput mkaput requested review from mkaput and orizi October 12, 2023 12:04
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @maciektr and @orizi)

a discussion (no related file):
We'd like to land this change before 2.3.0-rc2 is released because technically this is breaking.



crates/cairo-lang-sierra/src/program.rs line 41 at r1 (raw file):

#[derive(Debug, Error)]
#[error("Invalid version")]

Unsupported Sierra program version

Code quote:

Invalid version

@maciektr maciektr force-pushed the maciektr/sierra-serde branch from 1846356 to fb734b2 Compare October 12, 2023 15:34
Copy link
Collaborator Author

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @mkaput and @orizi)


crates/cairo-lang-sierra/src/program.rs line 41 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

Unsupported Sierra program version

Done.

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr and @orizi)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)

@mkaput mkaput added this pull request to the merge queue Oct 12, 2023
Merged via the queue into starkware-libs:main with commit 0f0b378 Oct 12, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants