Removed faulty diagnostic on inlining over generated functions. (#6257)

crates/cairo-lang-lowering/src/inline/mod.rs

@@ -21,7 +21,9 @@ use crate::db::LoweringGroup;
 use crate::diagnostic::{
     LoweringDiagnostic, LoweringDiagnosticKind, LoweringDiagnostics, LoweringDiagnosticsBuilder,
 };
-use crate::ids::{ConcreteFunctionWithBodyId, FunctionWithBodyId, LocationId};
+use crate::ids::{
+    ConcreteFunctionWithBodyId, FunctionWithBodyId, FunctionWithBodyLongId, LocationId,
+};
 use crate::lower::context::{VarRequest, VariableAllocator};
 use crate::utils::{InliningStrategy, Rebuilder, RebuilderEx};
 use crate::{
@@ -33,15 +35,16 @@ pub fn get_inline_diagnostics(
     db: &dyn LoweringGroup,
     function_id: FunctionWithBodyId,
 ) -> Maybe<Diagnostics<LoweringDiagnostic>> {
-    let semantic_function_id = function_id.base_semantic_function(db);
+    let inline_config = match function_id.lookup_intern(db) {
+        FunctionWithBodyLongId::Semantic(id) => db.function_declaration_inline_config(id)?,
+        FunctionWithBodyLongId::Generated { .. } => InlineConfiguration::None,
+    };
     let mut diagnostics = LoweringDiagnostics::default();
 
-    if let InlineConfiguration::Always(_) =
-        db.function_declaration_inline_config(semantic_function_id)?
-    {
+    if let InlineConfiguration::Always(_) = inline_config {
         if db.in_cycle(function_id, crate::DependencyType::Call)? {
             diagnostics.report(
-                semantic_function_id.untyped_stable_ptr(db.upcast()),
+                function_id.base_semantic_function(db).untyped_stable_ptr(db.upcast()),
                 LoweringDiagnosticKind::CannotInlineFunctionThatMightCallItself,
             );
         }

crates/cairo-lang-sierra-generator/src/ap_change_test_data/tests

@@ -82,16 +82,11 @@ fn not_cycle() {
 #[inline(always)]
 fn cycle_if_some(x: Option<felt252>) {
     match x {
-        Option::Some(x) => { cycle(x); },
+        Option::Some(x) => while x != 0 {},
         Option::None => {},
     }
 }
 
-fn cycle(x: felt252) -> felt252 {
-    cycle(x)
-}
-
 //! > result
 not_cycle: ap_change=Ok(Unknown), has_cycles=Ok(true)
 cycle_if_some: ap_change=Ok(Unknown), has_cycles=Ok(true)
-cycle: ap_change=Ok(Unknown), has_cycles=Ok(true)