-
Notifications
You must be signed in to change notification settings - Fork 107
chore: remove &self in AccountTransaction::handle_fee #1817
base: main
Are you sure you want to change the base?
Conversation
@noaov1 any opinion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Subsegment and @tdelabro)
crates/blockifier/src/transaction/account_transaction.rs
line 306 at r3 (raw file):
fn handle_fee<S: StateReader>(
Why did you add an additional new line?
Code quote:
}
fn handle_fee<S: StateReader>(
It may be a misoperation during merge conflict. I will modify it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tdelabro)
@noaov1 thanks for the reviews. Can you also trigger the workflow? |
#1770
This change is