Skip to content

feat: handling of get-starknet v5 #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PhilippeR26
Copy link
Collaborator

Motivation and Resolution

Add handling of Starknet Wallets with get-starknet V5 library.

Usage related changes

Class WalletAccountV5 has been added.
Namespace walletV5 has been also added.
Detailed usage in the guide.

Development related changes

  • In package.json, add of "@wallet-standard/features" to get the type for events (not re-exported by get-starknet).
  • Add of "@starknet-io/get-starknet/wallet-standard/features". As get-starknet V5 is not yet released, exact import names are uncertain. That's why this PR is initially tagged as draft. To be finalized once get-starknet released.
  • Except events handling (only one event in get-starknet v5), few changes from V4.
  • As with WalletAccount V4, it's not possible to test V5 in test suite. Extensive tests will be performed once V5 released, prior to remove the draft tag of this PR.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes in code (API docs will be generated automatically)
  • All tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant