Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a tentative/proposal to integrate support of web wallets in
get-starknet
. This PR includes modifications in bothcore
andui
packages, as well as inexample
Dapp. It also provides a sample web wallet (web_wallet_mock
) with WebauthN support. To test Dapp <-> Web wallet connection,pnpm dev
inweb_wallet_mock
folder)Register
Authenticate
pnpm dev
inexample
folder)However, I think that GetStarknetResult interface needs to be reviewed/refactored to properly abstract Web wallet as well as Extension wallet:
getAvailableWallets
,getDiscoveryWallets
,getWebWallet
introduce some kind of redundancy and confusion IMO. Thus, I am not fully satisfied the way I have integrate web wallet support even if it can make the job nowadays. I am willing to discuss/exchange, if you have any proposal.Thanks,