Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests, filter operators against scalar column datatypes #1528

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Add unit tests, filter operators against scalar column datatypes #1528

merged 6 commits into from
Oct 11, 2024
+585 −4

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Oct 10, 2024

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Yuqi-Du Yuqi-Du requested a review from a team as a code owner October 10, 2024 18:25
tatu-at-datastax
tatu-at-datastax approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- had some question on mapping of CQL types to Java types; those may be fine but thought to ask. Approving, assuming they are fine (you can change or not as you think is best).

@Yuqi-Du Yuqi-Du merged commit b7fdd8a into main Oct 11, 2024
3 checks passed
@Yuqi-Du Yuqi-Du deleted the yuqi/add-unit-tests-filter-scalar branch October 11, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuqi-Du @tatu-at-datastax