Add one IT for binary vector support #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/io/stargate/sgv2/jsonapi/api/v1/VectorSearchIntegrationTest.java
Outdated
Show resolved
Hide resolved
tatu-at-datastax
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the previous PR #1506, one suggestion was verifying whether the decoded vector dimension matched the vector definition. I thought we needed to explicitly verify it somewhere in the code but was not sure where was the best place. So I merged that PR first and tried to figure it out later. Then I realized we can defer the vector dimension verification to DB - the same as the normal vector array value.
So I don't add any code but add one Integration test to make sure it works.
Which issue(s) this PR fixes:
Fixes #1494
Checklist