Fix #1442: add codecs for UUID type(s) #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
commented
Oct 8, 2024
| @@ -48,6 +48,10 @@ public abstract class JSONCodecRegistries { | |||
| JSONCodecs.DURATION_FROM_STRING, | |||
| JSONCodecs.TIME_FROM_STRING, | |||
| JSONCodecs.TIMESTAMP_FROM_STRING, | |||
| // UUID codecs | |||
| JSONCodecs.UUID_FROM_STRING, | |||
| JSONCodecs.TIMEUUID_FROM_STRING, | |||
There was a problem hiding this comment.
Although we won't allow creation of "timeuuid" type, we do allow read/write, for which codec needed
There was a problem hiding this comment.
Sorry, I may miss the context for this one.
Why do we not allow "timeuuid" type?
There was a problem hiding this comment.
I am not 100% sure; I think it may be considered confusing thing -- you can store time-based UUIDs in "uuid" column anyway. And it is "Cassandraism" so hiding it may improve user experience.
Still: we can add support easily in future, if we so decide, but right now spreadsheet includes type as unsupported.
tatu-at-datastax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds codec impls, tests (unit, integration) for cql "uuid" and "timeuuid" types.
Which issue(s) this PR fixes:
Fixes #1442
Checklist