Table filter refactor #1490
Merged
Table filter refactor #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for #1424, will need tablemetadta on the collectionschema object it was a giant mess, still is, but trying to cleanup gradually
runs, not all unit tests checked Adds OperationAttempt as a base "task" that any operation runs, example in InsertTableOperation and InsertManyCommandResolver No tests written yet.
…tempt' into table-filter-where-clause
…tempt' into table-filter-where-clause
…tempt' into table-filter-where-clause
…TableInsertAttempt
Because there are several ways we create this, the builder is used in the work for OperationAttempt
that is where is is used
added driver profile reset logging to Debug
…tempt' into table-filter-where-clause # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/service/resolver/InsertManyCommandResolver.java # src/main/java/io/stargate/sgv2/jsonapi/service/resolver/InsertOneCommandResolver.java # src/main/java/io/stargate/sgv2/jsonapi/service/schema/collections/CollectionSchemaObject.java
(TODOs for corner cases and blob)
…ause # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/service/operation/InsertAttempt.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/ReadAttempt.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/query/CQLOption.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/DeleteTableOperation.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/TableInsertAttempt.java # src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/TableReadAttemptBuilder.java # src/main/java/io/stargate/sgv2/jsonapi/service/resolver/FindOneCommandResolver.java # src/test/java/io/stargate/sgv2/jsonapi/api/v1/tables/FindOneTableIntegrationTest.java
…ause # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/exception/ErrorCodeV1.java
quick tests from postman for all the rules except checkComparisonFilterAgainstDuration warnNotEqUnsupportedByIndexing
amorton
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist