Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unicode conversion pre-parsing for sparql #40

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add unicode conversion pre-parsing for sparql #40

wants to merge 5 commits into from

Conversation

joshhk72
Copy link
Contributor

@joshhk72 joshhk72 commented Sep 21, 2020 •
edited
Loading

  • Works by keeping track of the indices of replaced codepoints

Notes:

  • Is it worth making this work with suggestions as well? (should the language server provide suggestions for S\u0045LE as it would for SELE (being completed to SELECT for SPARQL).

@joshhk72 joshhk72 marked this pull request as ready for review September 23, 2020 19:16
@joshhk72 joshhk72 requested review from jmrog and removed request for anneeb September 28, 2020 15:18
@anneeb
Copy link
Contributor

anneeb commented Sep 30, 2020

Converting this back to a draft for now to reflect that we want to wait for server support before releasing

@anneeb anneeb marked this pull request as draft September 30, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrog jmrog Awaiting requested review from jmrog

@anneeb anneeb Awaiting requested review from anneeb anneeb is a code owner

@SpiralP SpiralP Awaiting requested review from SpiralP SpiralP will be requested when the pull request is marked ready for review SpiralP is a code owner

@mysticfalconvt mysticfalconvt Awaiting requested review from mysticfalconvt mysticfalconvt will be requested when the pull request is marked ready for review mysticfalconvt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshhk72 @anneeb