Adds datasource and some server api calls #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scardena
commented
Mar 12, 2021
| @@ -275,7 +276,6 @@ def new_user(self, username, password, superuser=False): | |||
|
|
|||
| self.client.post('/admin/users', json=meta) | |||
| return self.user(username) | |||
| return User(username, self.client) | |||
There was a problem hiding this comment.
this is never reachable afaict, so I am removing this.
scardena
force-pushed
the
feature/adds_extra_api_calls
branch
3 times, most recently
from
55120c1
to
3123873
Compare
igable
suggested changes
Mar 12, 2021
There was a problem hiding this comment.
Looks good.
Can you add some tests for datasource here: https://github.com/stardog-union/pystardog/blob/develop/test/test_admin.py
Also can we get a issue created for this PR in Github.
Nit: maybe a better name for the PR is something like "add datasource api"
buzztroll
suggested changes
Mar 30, 2021
scardena
force-pushed
the
feature/adds_extra_api_calls
branch
2 times, most recently
from
97ea6f6
to
dfe8a9b
Compare
scardena
force-pushed
the
feature/adds_extra_api_calls
branch
3 times, most recently
from
1fec903
to
6581a39
Compare
scardena
force-pushed
the
feature/adds_extra_api_calls
branch
5 times, most recently
from
c994641
to
44bf6c8
Compare
scardena
force-pushed
the
feature/adds_extra_api_calls
branch
from
44bf6c8
to
0822f57
Compare
scardena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47, and adds extra server api calls. there are still several api calls to add, so I am adding only the ones required for RBAC testing for now.
still WIP, I need to add some admin api calls, and haven't checked but a few that are also required for RBAC might: