Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexiDAG] fix force upgrade test #4075

Merged
merged 21 commits into from
May 18, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bfc6805
[flexiDAG] fixed mpm integration test
welbon May 16, 2024
10cb560
[flexiDAG] fixed mpm integration test
welbon May 16, 2024
7c8121f
[flexiDAG] new binary for framework version
welbon May 16, 2024
d41e8b1
[flexiDAG] debug test
welbon May 16, 2024
ebc6cb2
[flexiDAG] fixed force-deploy testcase
welbon May 16, 2024
ed9bbb0
[flexiDAG] fixed force-deploy testcase binary files
welbon May 16, 2024
14d7cd6
[fix-testcase] fixed the testcase for force upgrade
welbon May 17, 2024
65e8042
[fix-testcase] revert upgrade block number for test env
welbon May 17, 2024
0fc5c54
[fix-testcase] remove some log
welbon May 17, 2024
a6f9371
[fix-testcase] changed some comment
welbon May 17, 2024
4a321cd
[fix-testcase] changed some comment
welbon May 17, 2024
3834faf
[fix-testcase] fixed error from check_commit.sh
welbon May 17, 2024
147a348
[fix-testcase] fixed build and test workflow pull branch from `dag-mi…
welbon May 17, 2024
0e763ee
[fix-testcase] To ensure uniqueness, `StateView.get_block_metadata_v2…
welbon May 17, 2024
cd5af12
[fix-testcase] Reindex framework repository version
welbon May 17, 2024
f2dbd79
[fix-testcase] fixed cargo clippy
welbon May 17, 2024
3ad1fe0
[fix-testcase] fixed cargo fmt
welbon May 17, 2024
9f0c009
[fix-testcase] fixed StarcoinFramework initialize using StdlibVersion…
welbon May 17, 2024
9c13408
update scripts
simonjiao May 17, 2024
2941b0c
Revert "[fix-testcase] To ensure uniqueness, `StateView.get_block_met…
simonjiao May 18, 2024
6b0aa1e
Only execute extra txn when stdlib version is 11
simonjiao May 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ starcoin-crypto = { git = "https://github.com/starcoinorg/starcoin-crypto", rev
starcoin-decrypt = { path = "commons/decrypt" }
starcoin-dev = { path = "vm/dev" }
starcoin-executor = { path = "executor" }
starcoin-framework = { git = "https://github.com/starcoinorg/starcoin-framework", rev = "2966e3f6a04aef43a0e29e0cfc04d2d11290716d" }
starcoin-framework = { git = "https://github.com/starcoinorg/starcoin-framework", rev = "85a333bb1d12331581a8cd03a8b661f37101bf64" }
starcoin-genesis = { path = "genesis" }
starcoin-logger = { path = "commons/logger" }
starcoin-metrics = { path = "commons/metrics" }
Expand Down
6 changes: 4 additions & 2 deletions chain/src/chain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1247,8 +1247,9 @@ impl BlockChain {
verify_block!(
VerifyBlockField::State,
state_root == header.state_root(),
"verify legacy block:{:?} state_root fail",
"verify legacy block:{:?} state_root fail, executed_accumulator_root:{:?}, header.txn_accumulator_root(): {:?}",
block_id,
state_root, header.txn_accumulator_root()
);
let block_gas_used = vec_transaction_info
.iter()
Expand Down Expand Up @@ -1283,7 +1284,8 @@ impl BlockChain {
verify_block!(
VerifyBlockField::State,
executed_accumulator_root == header.txn_accumulator_root(),
"verify block: txn accumulator root mismatch"
"verify block: txn accumulator root mismatch! executed_accumulator_root: {:?}, header.txn_accumulator_root(): {:?} ",
executed_accumulator_root, header.txn_accumulator_root()
);

watch(CHAIN_WATCH_NAME, "n23");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,33 @@ use starcoin_vm_types::{account_config, state_view::StateReaderExt};
use std::str::FromStr;
use test_helper::executor::get_balance;

#[stest::test]
pub fn test_force_upgrade_generate_block() -> anyhow::Result<()> {
let mut genesis_config = BuiltinNetworkID::Test.genesis_config().clone();
genesis_config.stdlib_version = StdlibVersion::Version(11);
let net = ChainNetwork::new(
BuiltinNetworkID::Test.into(),
genesis_config,
);

let force_upgrade_height = get_force_upgrade_block_number(&net.chain_id());
assert!(force_upgrade_height >= 2);
let initial_blocks = force_upgrade_height - 2;

let block_chain = test_helper::gen_blockchain_with_blocks_for_test(initial_blocks, &net)?;
assert_eq!(block_chain.current_header().number(), initial_blocks);

Ok(())
}

#[stest::test]
pub fn test_force_upgrade_1() -> anyhow::Result<()> {
let mut genesis_config = BuiltinNetworkID::Test.genesis_config().clone();
genesis_config.stdlib_version = StdlibVersion::Version(11);
let net = ChainNetwork::new(BuiltinNetworkID::Test.into(), genesis_config);
let net = ChainNetwork::new(
BuiltinNetworkID::Test.into(),
genesis_config,
);

let force_upgrade_height = get_force_upgrade_block_number(&net.chain_id());
assert!(force_upgrade_height >= 2);
Expand Down
4 changes: 2 additions & 2 deletions config/src/genesis_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ pub static G_TEST_CONFIG: Lazy<GenesisConfig> = Lazy::new(|| {
),
genesis_key_pair: Some((Arc::new(genesis_private_key), genesis_public_key)),
time_service_type: TimeServiceType::MockTimeService,
stdlib_version: StdlibVersion::Version(12),
stdlib_version: StdlibVersion::Latest,
dao_config: DaoConfig {
voting_delay: 60_000, // 1min
voting_period: 60 * 60 * 1000, // 1h
Expand All @@ -775,7 +775,7 @@ pub static G_DEV_CONFIG: Lazy<GenesisConfig> = Lazy::new(|| {
let mut gas_constant = G_TEST_GAS_CONSTANTS.clone();
gas_constant.min_price_per_gas_unit = 1;

let stdlib_version = StdlibVersion::Version(12);
let stdlib_version = StdlibVersion::Latest;
GenesisConfig {
genesis_block_parameter: GenesisBlockParameterConfig::Static(GenesisBlockParameter {
parent_hash: HashValue::sha3_256_of(b"starcoin_dev"),
Expand Down
5 changes: 4 additions & 1 deletion scripts/build_stdlib.sh
simonjiao marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,7 @@ for arg in "${args[@]}"; do
cmd+=" --arg ${arg}"
done

eval $cmd
eval $cmd

# build genesises
cargo run --bin starcoin-genesis
Binary file modified vm/stdlib/compiled/12/11-12/stdlib.blob
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/11-12/stdlib/038_Block.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/11-12/stdlib/049_FlexiDagConfig.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/11-12/stdlib/065_StdlibUpgradeScripts.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/11-12/stdlib/066_Genesis.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/stdlib/038_Block.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/stdlib/049_FlexiDagConfig.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/stdlib/065_StdlibUpgradeScripts.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/12/stdlib/066_Genesis.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/latest/stdlib/038_Block.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/latest/stdlib/049_FlexiDagConfig.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/latest/stdlib/065_StdlibUpgradeScripts.mv
Binary file not shown.
Binary file modified vm/stdlib/compiled/latest/stdlib/066_Genesis.mv
Binary file not shown.
2 changes: 1 addition & 1 deletion vm/vm-runtime/src/force_upgrade_management.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub const FORCE_UPGRADE_BLOCK_NUMBER: u64 = 17500000;

pub fn get_force_upgrade_block_number(chain_id: &ChainId) -> u64 {
if chain_id.is_test() {
50
10
simonjiao marked this conversation as resolved.
Show resolved Hide resolved
} else if chain_id.is_dev() {
60
} else if chain_id.is_halley() || chain_id.is_proxima() {
Expand Down
Loading