Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parallel executor] table storage parallel #3891

Merged
merged 12 commits into from
Jul 31, 2023
Merged

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented May 4, 2023

Pull request type

refactor table storage for block parallel execution

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from nanne007 as a code owner May 4, 2023 09:56
@nkysg nkysg changed the title Refactor table storage [table storage] Refactor table storage May 4, 2023
@nkysg nkysg requested review from sanlee42, welbon and jackzhhuang and removed request for nanne007 May 4, 2023 10:02
@nkysg nkysg changed the title [table storage] Refactor table storage [parallel executor] table storage parallel May 4, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #3891 (1f6a48c) into master (62f2b39) will increase coverage by 0.37%.
Report is 3 commits behind head on master.
The diff coverage is 84.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3891      +/-   ##
==========================================
+ Coverage   53.73%   54.09%   +0.37%     
==========================================
  Files         618      621       +3     
  Lines       68014    68466     +452     
==========================================
+ Hits        36539    37029     +490     
+ Misses      31475    31437      -38     
Flag Coverage Δ
unittests 54.09% <84.28%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/peer-watcher/src/lib.rs 6.25% <0.00%> (ø)
cmd/starcoin/src/node/network/call_peer_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/node/network/get_address_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/node/network/known_peers_cmd.rs 0.00% <ø> (ø)
cmd/starcoin/src/node/sync/start_cmd.rs 0.00% <ø> (ø)
config/src/network_config.rs 80.00% <ø> (ø)
network-p2p/core/src/delegates.rs 100.00% <ø> (ø)
network-p2p/core/src/lib.rs 36.07% <ø> (ø)
network-p2p/core/src/server.rs 93.75% <ø> (ø)
network-p2p/derive/src/helper.rs 76.32% <ø> (ø)
... and 49 more

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224e299...1f6a48c. Read the comment docs.

@nkysg nkysg force-pushed the refactor_table_storage branch 2 times, most recently from abe30e2 to 6d29ad5 Compare July 25, 2023 03:20
state/statedb/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@simonjiao simonjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkysg It looks good to me. Please checkout the comment above.

@nkysg nkysg merged commit 236c0f2 into master Jul 31, 2023
6 of 7 checks passed
@nkysg nkysg deleted the refactor_table_storage branch July 31, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants