Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve function name of ExecutionFailure in transaction detail #170

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coldnight
Copy link

WIP

This will be ready only if this PR starcoinorg/starcoin#3464 has been deployed.


Related: starcoinorg/starcoin#3450

@coldnight coldnight force-pushed the feat-explain-transaction-failure branch from 12e3faa to 4614d34 Compare June 14, 2022 08:00
@jolestar jolestar requested a review from uvd July 11, 2022 03:28
@jolestar
Copy link
Member

@yourmoonlight the v1.11.12 includes the starcoinorg/starcoin#3450, please update and deploy the v1.11.12 to the RPC nodes.

@coldnight
Copy link
Author

I'll fix the conflicts.

@coldnight coldnight force-pushed the feat-explain-transaction-failure branch from 4614d34 to edd3ca2 Compare July 11, 2022 03:56
@yourmoonlight
Copy link

@yourmoonlight the v1.11.12 includes the starcoinorg/starcoin#3450, please update and deploy the v1.11.12 to the RPC nodes.

ok

@uvd
Copy link
Collaborator

uvd commented Jul 11, 2022

it pushed https://test.stcscan.io/ you can see see O_O @coldnight

@jolestar
Copy link
Member

The seed nodes do not upgrade yet.

@uvd
Copy link
Collaborator

uvd commented Jul 11, 2022

ok,先推送到了测试网 切换网络看是不是正常

@yourmoonlight
Copy link

ok,先推送到了测试网 切换网络看是不是正常

@uvd @jolestar 现在部署完毕了。

@coldnight
Copy link
Author

本地测了一下无法正常工作,应该是由于 sagas 不支持 async,而目前是直接通过 sagas 调用的 SDK 异步接口。

@coldnight coldnight marked this pull request as draft July 12, 2022 04:01
@uvd
Copy link
Collaborator

uvd commented Jul 12, 2022

ok 需要帮助可以找我

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants