chore: making cli standard

stanleyyconsensys · Jun 18, 2024 · 9b54a36 · 9b54a36
1 parent 0a2a278
commit 9b54a36
Show file tree

Hide file tree

Showing 11 changed files with 4,124 additions and 2,727 deletions.
diff --git a/package.json b/package.json
@@ -9,11 +9,12 @@
     "packages/*"
   ],
   "scripts": {
-    "setup": "yarn workspaces foreach run setup",
-    "build": "yarn workspaces foreach run build",
-    "test": "yarn workspace @consensys/starknet-snap run test",
-    "lint": "yarn workspaces foreach run lint",
-    "clean": "yarn workspaces foreach run clean",
+    "allow-scripts": "yarn workspaces foreach --parallel --interlaced --verbose run allow-scripts",
+    "clean": "yarn workspaces foreach --parallel --interlaced --verbose run clean",
+    "build": "yarn workspaces foreach --parallel --interlaced --verbose run build",
+    "lint": "yarn workspaces foreach --parallel --interlaced --verbose run lint",
+    "start": "yarn workspaces foreach --parallel --interlaced --verbose run start",
+    "test": "yarn workspaces foreach --parallel --interlaced --verbose run test",
     "prepare": "husky install"
   },
   "devDependencies": {
@@ -23,5 +24,8 @@
   },
   "resolutions": {
     "luxon@^3.2.1": "patch:luxon@npm%3A3.3.0#./.yarn/patches/luxon-npm-3.3.0-bdbae9bfd5.patch"
+  },
+  "engines": {
+    "node": ">=18.6.0"
   }
 }
diff --git a/packages/starknet-snap/README.md b/packages/starknet-snap/README.md
@@ -1,3 +1,3 @@
 # starknet-snap
 
-The MetaMask Snap for Starknet.
+The MetaMask Snap for Starknet.
diff --git a/packages/starknet-snap/openrpc/starknet_snap_api_openrpc.json b/packages/starknet-snap/openrpc/starknet_snap_api_openrpc.json
@@ -1323,12 +1323,7 @@
         "properties": {
           "type": {
             "type": "string",
-            "enum": [
-              "DECLARE",
-              "DEPLOY",
-              "DEPLOY_ACCOUNT",
-              "INVOKE_FUNCTION"
-            ]
+            "enum": ["DECLARE", "DEPLOY", "DEPLOY_ACCOUNT", "INVOKE_FUNCTION"]
           },
           "payload": {
             "$ref": "#/components/schemas/INVOCATION_PAYLOAD"
@@ -1414,30 +1409,17 @@
       },
       "TXN_STATUS": {
         "type": "string",
-        "enum": [
-          "UNKNOWN",
-          "RECEIVED",
-          "PENDING",
-          "ACCEPTED_ON_L2",
-          "ACCEPTED_ON_L1",
-          "REJECTED"
-        ],
+        "enum": ["UNKNOWN", "RECEIVED", "PENDING", "ACCEPTED_ON_L2", "ACCEPTED_ON_L1", "REJECTED"],
         "description": "The status of the transaction. May be unknown in case node is not aware of it"
       },
       "VOYAGER_TXN_TYPE": {
         "type": "string",
-        "enum": [
-          "invoke",
-          "deploy"
-        ],
+        "enum": ["invoke", "deploy"],
         "description": "The txn type of the transaction from Voyager. May not be a full list here and subject to change"
       },
       "VOYAGER_TXN_STATUS": {
         "type": "string",
-        "enum": [
-          "Accepted on L2",
-          "Accepted on L1"
-        ],
+        "enum": ["Accepted on L2", "Accepted on L1"],
         "description": "The status of the transaction. May be unknown in case node is not aware of it"
       },
       "TYPED_DATA_SIGNATURE": {

diff --git a/packages/starknet-snap/package.json b/packages/starknet-snap/package.json
@@ -13,16 +13,16 @@
     "snap.manifest.json"
   ],
   "scripts": {
-    "setup": "yarn install --immutable && yarn allow-scripts",
     "build:clean": "yarn clean && yarn build",
     "build": "mm-snap build",
     "serve": "mm-snap serve",
-    "clean": "rimraf js && rimraf dist",
-    "watch": "mm-snap watch",
-    "prettier": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
-    "lint": "eslint . --max-warnings 0 -f json -o eslint-report.json",
-    "lint:fix": "eslint '**/*.{js,ts,tsx}' --fix",
+    "clean": "rimraf dist",
+    "start": "mm-snap watch",
     "test": "yarn run test:unit && yarn run cover:report",
+    "lint": "yarn lint:eslint && yarn lint:misc --check",
+    "lint:eslint": "eslint . --cache --ext js,ts",
+    "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write",
+    "lint:misc": "prettier '**/*.ts' '**/*.json' '**/*.md' '!CHANGELOG.md' --ignore-path .gitignore",
     "test:unit": "nyc --check-coverage --statements 80 --branches 80 --functions 80 --lines 80 mocha --colors -r ts-node/register \"test/**/*.test.ts\"",
     "cover:report": "nyc report --reporter=lcov --reporter=text"
   },

diff --git a/packages/starknet-snap/snap.manifest.json b/packages/starknet-snap/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/ConsenSys/starknet-snap.git"
   },
   "source": {
-    "shasum": "vVFyA2r3PuADhGuwrnvREDPCLnSidbQzT3lxf9uzvOA=",
+    "shasum": "Rd+6Z0ZntrocRN8+Xrcauh9gntOOY1IEnBPLEPNMGrU=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",