Remove shortid package

stanlemon · Sep 16, 2023 · bff89f3 · bff89f3
1 parent da2a418
commit bff89f3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 21 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/server-with-auth/package.json b/packages/server-with-auth/package.json
@@ -27,7 +27,6 @@
     "lowdb-node": "^3.0.2",
     "passport": "^0.6.0",
     "passport-jwt": "^4.0.1",
-    "shortid": "^2.2.16",
     "uuid": "^9.0.0"
   },
   "devDependencies": {
@@ -36,4 +35,4 @@
     "nodemon": "^3.0.1",
     "supertest": "^6.3.3"
   }
-}
+}
diff --git a/packages/server-with-auth/src/createAppServer.js b/packages/server-with-auth/src/createAppServer.js
@@ -5,7 +5,6 @@ import {
 } from "@stanlemon/server";
 import passport from "passport";
 import { Strategy as JwtStrategy, ExtractJwt } from "passport-jwt";
-import shortid from "shortid";
 import defaultUserSchema from "./schema/user.js";
 import checkAuth from "./checkAuth.js";
 import auth from "./routes/auth.js";
@@ -50,7 +49,12 @@ export default function createAppServer(options) {
     console.warn("You need to specify a secret.");
   }
 
-  const secret = process.env.JWT_SECRET || shortid.generate();
+  const badSecret = "YOU_NEED_TO_SPECIFY_A_JWT_SECRET";
+  const secret = process.env.JWT_SECRET || badSecret;
+
+  if (secret === badSecret) {
+    console.warn("You need to specify a JWT secret.");
+  }
 
   passport.use(
     "jwt",

diff --git a/packages/server-with-auth/src/data/simple-users-dao.js b/packages/server-with-auth/src/data/simple-users-dao.js
@@ -1,7 +1,6 @@
 import { LowSync, MemorySync } from "lowdb";
 import { JSONFileSync } from "lowdb-node";
 import { v4 as uuidv4 } from "uuid";
-import shortid from "shortid";
 import bcrypt from "bcryptjs";
 
 const DEFAULT_ADAPTER =
@@ -29,7 +28,7 @@ export default class SimpleUsersDao {
   }
 
   generateVerificationToken() {
-    return shortid.generate();
+    return uuidv4();
   }
 
   getUserById = (userId) => {