Added filename and signature style regulations #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like filename, can we revisit signature in person? |
parthsarin
reviewed
Aug 23, 2020
See meeting agenda for 8/23/20
parthsarin
reviewed
Aug 23, 2020
STYLE.md
Outdated
Comment on lines
49
to
54
| # /usr/bin/env python3 | ||
|
|
||
| ''' | ||
| File: filename.py | ||
| ----------------- | ||
| ''' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
parthsarin
reviewed
Aug 23, 2020
Comment on lines
+58
to
+65
| ```python | ||
| # /usr/bin/env python3 | ||
|
|
||
| ''' | ||
| File: filename.py | ||
| ----------------- | ||
| ''' | ||
| ``` |
There was a problem hiding this comment.
I hate that this was such a meandering process to get here... Can we remove the line between the shebang and use double quotes for the comment? Good to merge after your OK, @cooper-mj.
Suggested change
| ```python | |
| # /usr/bin/env python3 | |
| ''' | |
| File: filename.py | |
| ----------------- | |
| ''' | |
| ``` | |
| # /usr/bin/env python3 | |
| """ | |
| File: filename.py | |
| ----------------- | |
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.