Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix in PropertiesUtils #97

Closed
wants to merge 2 commits into from

Conversation

elepedus
Copy link

Incorrect conditional logic was causing prefixes to be removed when keepPrefix was true and kept when it was false.

@AngledLuffa
Copy link
Contributor

Looks legit. I needed to switch the truth value on one of the uses
elsewhere in corenlp to make it work. Thanks!

On Sun, Oct 25, 2015 at 12:59 PM, Edmond Lepedus [email protected]
wrote:

Incorrect conditional logic was causing prefixes to be removed when

keepPrefix was true and kept when it was false.

You can view, comment on, or merge this pull request online at:

#97
Commit Summary

  • Add .gitignore
  • Fix bug which was preventing the removal of property prefixes

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#97.

@gangeli
Copy link
Member

gangeli commented Oct 28, 2015

Closed with commit 7ffd9ba

@gangeli gangeli closed this Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants