Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak CLAUSAL_PASSIVE_SUBJECT's long name. #21

Closed
wants to merge 1 commit into from

Conversation

markwoon
Copy link

Minor change to give CLAUSAL_SUBJECT and CLAUSAL_PASSIVE_SUBJECT distinct long names.

Minor change to give CLAUSAL_SUBJECT and CLAUSAL_PASSIVE_SUBJECT distinct long names.
@AngledLuffa
Copy link
Contributor

Thanks for pointing that out,

John

On Fri, Mar 21, 2014 at 5:55 PM, Mark Woon [email protected] wrote:

Minor change to give CLAUSAL_SUBJECT and CLAUSAL_PASSIVE_SUBJECT distinct

long names.

You can merge this Pull Request by running

git pull https://github.com/markwoon/CoreNLP master

Or view, comment on, or merge it at:

#21
Commit Summary

  • Tweak CLAUSAL_PASSIVE_SUBJECT's long name.

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/21
.

@markwoon
Copy link
Author

Does that mean this pull request will be accepted?

@AngledLuffa
Copy link
Contributor

Actually it was easier to copy it and submit it locally. You may already
see the change
On Mar 22, 2014 8:28 PM, "Mark Woon" [email protected] wrote:

Does that mean this pull request will be accepted?

Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-38371897
.

@markwoon
Copy link
Author

Ah. Thanks. Is github just a mirror of your repository?

@AngledLuffa
Copy link
Contributor

Pretty much
On Mar 22, 2014 9:23 PM, "Mark Woon" [email protected] wrote:

Ah. Thanks. Is github just a mirror of your repository?

Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-38373564
.

@markwoon markwoon closed this Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants