Ssurgeon #1345
Merged
Ssurgeon #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of an iterator to find the edges to be deleted (to ensure the iteration doesn't mess up the maps while iterating)
…parately before using the argsbox (otherwise SetRoots won't correctly parse, for example)
…s of some basic setRoots operations
This operation puts the named edge into the SemgrexMatcher after relabeling something. If the edge already exists, a duplicate is not created. Add a test of this operation
… need to turn generic keys which can't be translated into SsurgeonParseException, and will also want to add a position to the AddDep
…t of sentence) and + (end of sentence, also the default). Need to process -word and +word as well. Will also want to update the SemgrexMatcher so that potentially further operations are possible.
…ate the values on a node
…heck for unreadable attributes at the same time as checking for illegal attributes - this will make EditNode also support checking those attributes
…can report the error line no matter where the error occurs (eg, if it bubbles up from someplace that doesn't know about the editline)
…e SemanticGraph. Includes a test of that functionality
…e edges with the proper dependency scheme. Also, use the version of GrammaticalRelation.valueOf which creates an edge if it doesn't currently exist. This will allow for unknown dependency schemes to work for the most part (although perhaps some bug will crop up anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a bunch of outstanding differences between the paper and the way the tool actually operates: