Semgraph, semgrex, and ssurgeon improvements #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly changes the meaning of existing expressions, since it was previously possible to assign multiple words to the same index, but that was a bad feature anyway
…when looking at the collection of roots Also, add a test of if a node is a root or not
…rex. Implementations of the Spacy extensions of the same operations Add a short test of adjacent left/right, left/right
…ntation of semgrex: <++ <-- >++ <--
…on and add a test of the feature
- Pass around a map for matching edges - Setting ~name on a relation in the SemgrexPattern keeps the matched edge in the map - this only applies to relations which are immediate parent or child relations: > >-- >++ < <-- <++ if set on any other relation, an exception is thrown (test included) - includes a test of the edge naming and backreferences for the various relations - document the feature in the SemgrexPattern javadoc
not clear how this ever worked in the first place
…rk multiple times over a single graph instead of returning all possible single modifications of the graph
… SsurgeonEdit evaluation. Add a bunch of notes to the operations, including some notes on whether or not they are used in RTE
…it no longer does anything new Can now use valueOf() and assertEquals to make sure the graph is as expected in the unittest - much simpler than taking apart the graph Leave a comment on something we need to figure out regarding the iteration
Include a test of the basic operation using a semgrex which searches for unattached nodes Also check the operation of resetting the roots when a root is pruned
…(it was currently unused everyone, including RTE, so changing the interface should be no harm done)
…ng. This is the only bugfix needed to make killNonRooted work as expected
…bel of the edge to be deleted. Essentially, it deletes all the edges between the two nodes. Still need to test the gov / dep wildcard variants of those - they seem less useful when calling iterate(), though
…reNLP side of an Ssurgeon interface for Python. Included in this change is adding optional tokens to the DependencyGraph
… doesn't) change the graph Adds a test of the multi-pattern iterate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to semgrex & friends. Includes a CLI for Ssurgeon which can be used from Python (or anything else communicating via protobuf)