Best offset prefetcher #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlitz
reviewed
Jul 31, 2020
src/best_offset_prefetcher.h
Outdated
|
|
||
| // num run throughs to make before round over | ||
| const uint64_t RND_MAX = 100; | ||
| //const uint64_t RND_MAX = 50; |
There was a problem hiding this comment.
remove multiple constants. If you believe these should be configurable, add a new parameter that can be defined via the cfg file.
| @@ -76,7 +76,7 @@ void TraceReaderMemtrace::binaryGroupPathIs(const std::string &_path) { | |||
| error.c_str()); | |||
| return; | |||
| } | |||
| module_mapper_ = module_mapper_t::create(directory_.modfile_bytes, | |||
There was a problem hiding this comment.
hmm is this a current bug? If yes please extract it into a separate commit/pull request
src/best_offset_prefetcher.h
Outdated
| uint64_t current_round; | ||
| uint64_t test_offset_index; | ||
| uint64_t current_offset; | ||
| #ifndef TEST |
There was a problem hiding this comment.
remove and add some actual stats (look how the other prefetchers are doing it).
Can you think of other useful stats besides emitted prefetches? This is very helpful for quick debugging the out file if things do not perform like expected.
hlitz
reviewed
Jul 31, 2020
…ved is to add configurability to the prefetcher from the configuration files.
Cleaned up code a bit. Cleand up syntax of source files. Next step before pull request approved is to add configurability to the prefetcher from the configuration files. Fixed up code to standards. Added best offset prefetcher source files to forked branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the implementation of the best offset prefetcher.