Revise SFT File #793
Open
Revise SFT File #793
+46
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlwh
reviewed
Nov 12, 2024
src/levanter/main/sft.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class SFTConfig(TrainLmConfig): |
There was a problem hiding this comment.
imho this should really not inherit from TrainLmConfig but just grab the parts you need
There was a problem hiding this comment.
I end up needing a lot of shared content with TrainLMConfig since I want to explicitly declare all variables in the marin experiment so i think it's better to inherit
There was a problem hiding this comment.
generally speaking it's a code smell when you inherit and don't use the stuff in the super
There was a problem hiding this comment.
Got it, I just changed it to not inherit and copied the attributes I need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to revise SFT file to avoid breaking changes to marin and for a request from @dlwh