-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop EOL ruby versions #26
Conversation
My 2¢: if everything works fine under Ruby 3.0, I'd rather keep it in the matrix (this goes for standardrb/standard, too, I just realized your previous PR also dropped 3.0 there), so that (1) we know whether it works and (2) we raise As for releasing the gems with a higher required_ruby_version, I think all of the core gems (standard, -performance, -custom) should move this property in lock step with one another, regardless. (I realize they're already out of sync). @camilopayan, thoughts on coordinating? |
Fair enough, makes sense to keep CI covering all supported versions, and I also see the argument for "lets only bump one marjor version at a time" in the gemspec. Just pushed commit here to restore 3.0 to CI matrix, and bump to 3.0.0 in the gemspec. Opened standardrb/standard#634 and standardrb/standard-rails#44 to coordinate if desired. |
Thanks for plugging away at all this @mjankowski -- there is one more included-by-default gem: https://github.com/standardrb/standard-custom you might want to look at for consistency |
Cool - will hit that one next. One random aside here ... https://github.com/standardrb/standard/blob/v1.37.0/config/default.yml#L3 should |
… yes? As is probably clear to you now this process is involved enough that the main repo would probably benefit from a brief documentation file explaining how to bump base Ruby version across all built-ins and plugins. Sorry this is so sprawling! |
From the studio that brought you standardrb/standard#633 and standardrb/standard-rails#42 comes ... this PR.
I did NOT yet bump the required ruby version in the gemspec ... can do so here or in subsequent PR if desired.