Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize whitespace #5

Closed
wants to merge 1 commit into from

Conversation

jonsterling
Copy link

To resolve #3.

First, I sterilized the tabs out. Then, I noticed that the whitespace conventions in the code were a bit haphazard, so I unified the code to (mostly?) conform to a single style. In particular:

  • remove trailing whitespace (whitespace at the end of a line)
  • in sig or struct block, indent two spaces
  • avoid vertical alignment based on lexical width in most cases (e.g. putting lots of spaces before a colon) because it is difficult to maintain, and was not consistently used in the first place
  • adopt a single style for indenting case expressions
  • adopt a single style for indenting let expressions
  • adopt a single style for indenting if expressions

Let me know if there's anything about the above stylistic choices that you would prefer I changed to something else! Whilst I have my personal preference, I care more that a project is internally consistent.

- sterilize tabs
- unify whitespace style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

whitespace is not consistent
1 participant